all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: 31006@debbugs.gnu.org
Subject: bug#31006: [PATCH] Handle quotation marks and apostrophes in ‘sgml-quote’
Date: Sun, 01 Apr 2018 11:59:35 +0300	[thread overview]
Message-ID: <83po3j7154.fsf@gnu.org> (raw)
In-Reply-To: <20180331170035.27048-1-mina86@mina86.com> (message from Michal Nazarewicz on Sat, 31 Mar 2018 18:00:35 +0100)

> From: Michal Nazarewicz <mina86@mina86.com>
> Date: Sat, 31 Mar 2018 18:00:35 +0100
> 
> To be able to use text in an HTML argument, quotation marks need
> to be replaced with an appropriate character reference.  Make
> ‘sgml-quote’ do that.
> 
> While at it, fix entiteis not being unquoted if they lack closing
> semicolon (e.g. ‘&amp’) occuring at the very end of a region.
> Even though unlikely, make ‘sgml-quote’ handle this scenario.
> 
> * lisp/textmodes/sgml-mode.el (sgml-quote): Handle quotation marks and
> apostrophes.  Match entities lacking semicolon at the end of regions.
> * test/lisp/textmodes/sgml-mode-tests.el (sgml-quote-works): New test
> case for ‘sgml-quote’ function.

Thanks, this LGTM, with a minor nit: the NEWS entry should be marked
"---", as sgml-quote is not currently documented in the Emacs manual.

Please wait for a few days to let others comment, and if nothing else
comes up, please push to the master branch with the above nit fixed.





  reply	other threads:[~2018-04-01  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-31 17:00 bug#31006: [PATCH] Handle quotation marks and apostrophes in ‘sgml-quote’ Michal Nazarewicz
2018-04-01  8:59 ` Eli Zaretskii [this message]
2018-04-07 10:20   ` Michał Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83po3j7154.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31006@debbugs.gnu.org \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.