From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Sat, 04 Aug 2018 09:07:42 +0300 Message-ID: <83pnyyu0k1.fsf@gnu.org> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533362795 3553 195.159.176.226 (4 Aug 2018 06:06:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Aug 2018 06:06:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 04 08:06:31 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flphu-0000pV-Sp for ged-emacs-devel@m.gmane.org; Sat, 04 Aug 2018 08:06:31 +0200 Original-Received: from localhost ([::1]:54049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flpjz-0001nq-Mf for ged-emacs-devel@m.gmane.org; Sat, 04 Aug 2018 02:08:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flpjJ-0001na-AV for emacs-devel@gnu.org; Sat, 04 Aug 2018 02:07:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flpjD-00061t-Pj for emacs-devel@gnu.org; Sat, 04 Aug 2018 02:07:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flpjD-00061i-M4; Sat, 04 Aug 2018 02:07:51 -0400 Original-Received: from [176.228.60.248] (port=1563 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1flpjD-0006n0-6H; Sat, 04 Aug 2018 02:07:51 -0400 In-reply-to: <86in4rgt1m.fsf@gmail.com> (message from Andy Moreton on Fri, 03 Aug 2018 20:16:05 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228143 Archived-At: > From: Andy Moreton > Date: Fri, 03 Aug 2018 20:16:05 +0100 > > Yes. Also perhaps change XBIGNUM to: > > INLINE struct Lisp_Bignum * > XBIGNUM (Lisp_Object a) > { > eassert (BIGNUMP (a)); > return XUNTAG (a, Lisp_Misc, struct Lisp_Bignum)->value; > } > > That allows "XBIGNUM(value)->value" to be replaced with "XBIGNUM(value)" > in all callers. That would go against the convention with all the other Xfoo macros. However, I see your point, and so perhaps an additional macro, XINTEGER, could call either XINT or XBIGNUM()->value, depending on the argument type?