From: Eli Zaretskii <eliz@gnu.org>
To: Gemini Lasswell <gazally@runbox.com>
Cc: emacs-devel@gnu.org
Subject: Re: list-threads
Date: Mon, 27 Aug 2018 21:48:45 +0300 [thread overview]
Message-ID: <83pny34pde.fsf@gnu.org> (raw)
In-Reply-To: <87efej3e2p.fsf@runbox.com> (message from Gemini Lasswell on Mon, 27 Aug 2018 10:38:06 -0700)
> From: Gemini Lasswell <gazally@runbox.com>
> Date: Mon, 27 Aug 2018 10:38:06 -0700
>
> I've just pushed an update to the scratch/list-threads branch which
> includes:
>
> - lisp/thread.el, the new home for thread-related Lisp functions.
>
> - A 'b' command in the *Threads* buffer which shows a backtrace of where
> the thread at point had yielded or was blocked at the moment you
> pressed 'b'.
>
> - Documentation and a NEWS entry.
>
> - Tests.
Thanks.
A few of comments:
. I'm not sure the section bout list-threads should be in the ELisp
manual. It's a user command. OTOH, list-processes is also
described in the ELisp manual, hmm...
. But if we decide to leave this section where it is, then it should
behave like any other section in that manual, which means variables
are described with @defvar.
. Please add a cross-reference to the section where make-thread is
described where you tell that the thread's name comes from that
call. Info manuals should always cross-link to the description of
each major topic when they refer to it, because people frequently
read the manual out of order.
. "Send a signal to the thread" is slightly misleading, because it
can be interpreted as talking about OS signals. Suggest to use
"signal the thread" instead. I'd also qualify that what each
thread does for each of the 2 signals is entirely up to the thread
(default is to exit on any signal).
. This text is slightly inaccurate:
Be aware that by the time you see the backtrace, the thread
may have resumed execution, and be in a different section of
code, or be completed.
I would rephrase like this:
Be aware that the backtrace is a snapshot; the thread could have
meanwhile resumed execution, and could be in a different state, or
could have exited.
. Will the new function backtrace--frames-from-thread (and its
subroutines) compile and work in an Emacs configured without
threads? If not, they should be conditioned by THREADS_ENABLED.
. Finally, I think the NEWS entry should be a bit longer, and should
say this is a new command.
next prev parent reply other threads:[~2018-08-27 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 1:11 list-threads Gemini Lasswell
2018-07-29 7:56 ` list-threads Michael Albinus
2018-07-29 8:37 ` list-threads Michael Albinus
2018-07-29 14:31 ` list-threads Gemini Lasswell
2018-07-29 17:31 ` list-threads Eli Zaretskii
2018-07-30 13:27 ` list-threads Gemini Lasswell
2018-07-30 17:21 ` list-threads Stefan Monnier
2018-07-30 14:59 ` list-threads Eli Zaretskii
2018-08-01 16:03 ` list-threads Gemini Lasswell
2018-08-01 16:37 ` list-threads Eli Zaretskii
2018-08-01 20:04 ` list-threads Gemini Lasswell
2018-08-02 13:53 ` list-threads Eli Zaretskii
2018-08-02 14:51 ` list-threads Gemini Lasswell
2018-08-27 17:38 ` list-threads Gemini Lasswell
2018-08-27 18:48 ` Eli Zaretskii [this message]
2018-09-09 15:44 ` list-threads Gemini Lasswell
2018-09-09 16:01 ` list-threads Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pny34pde.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.