From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sun, 06 Jan 2019 19:54:24 +0200 Message-ID: <83pnt9zn73.fsf@gnu.org> References: <83bm5d9wsc.fsf@gnu.org> <20181222205948.GF2244@macbook.localdomain> <838t0gapcj.fsf@gnu.org> <20181223135109.GA6568@macbook.localdomain> <83va3k8c79.fsf@gnu.org> <20181224020847.GC6568@macbook.localdomain> <83lg4e9a7q.fsf@gnu.org> <20181224173723.GH6568@macbook.localdomain> <838t085qx8.fsf@gnu.org> <20190105205314.GA28761@macbook.localdomain> <20190105210420.GA31354@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1546797189 13641 195.159.176.226 (6 Jan 2019 17:53:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Jan 2019 17:53:09 +0000 (UTC) Cc: behdad@behdad.org, far.nasiri.m@gmail.com, 33729@debbugs.gnu.org To: Khaled Hosny Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 06 18:53:04 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from listsout.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggCbe-0003Me-1d for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jan 2019 18:53:02 +0100 Original-Received: from localhost ([127.0.0.1]:46044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggCdk-0003wS-FK for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jan 2019 12:55:12 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:51273 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggCde-0003wK-AJ for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2019 12:55:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggCdb-00020v-4n for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2019 12:55:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggCda-00020W-Hz for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2019 12:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ggCdZ-0002XE-UN for bug-gnu-emacs@gnu.org; Sun, 06 Jan 2019 12:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jan 2019 17:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15467972929723 (code B ref 33729); Sun, 06 Jan 2019 17:55:01 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 6 Jan 2019 17:54:52 +0000 Original-Received: from localhost ([127.0.0.1]:48977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggCdP-0002Wk-ME for submit@debbugs.gnu.org; Sun, 06 Jan 2019 12:54:51 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:41930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggCdL-0002Wb-QQ for 33729@debbugs.gnu.org; Sun, 06 Jan 2019 12:54:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggCdI-0001s1-4F for 33729@debbugs.gnu.org; Sun, 06 Jan 2019 12:54:47 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggCdH-0001rM-0P; Sun, 06 Jan 2019 12:54:43 -0500 Original-Received: from [176.228.60.248] (port=4362 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ggCdF-0001hm-Tw; Sun, 06 Jan 2019 12:54:42 -0500 In-reply-to: <20190105210420.GA31354@macbook.localdomain> (message from Khaled Hosny on Sat, 5 Jan 2019 23:04:20 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154194 Archived-At: > Date: Sat, 5 Jan 2019 23:04:20 +0200 > From: Khaled Hosny > Cc: far.nasiri.m@gmail.com, behdad@behdad.org, 33729@debbugs.gnu.org > > I pushed a couple of commits that does this based on my limited > understanding of Emacs code, please check. Can you explain why you moved the call to hb_buffer_guess_segment_properties _after_ the code which sets some of the properties? I cannot find anything about that in the HarfBuzz documentation. Is this because guessing the unset properties can benefit from knowing the properties which _are_ set, such as the direction? I did it the other way around, because my mental model was: first set the defaults, then override them where better info is available. Thanks.