From: Eli Zaretskii <eliz@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Is it ok to use (redisplay), or should this be left to the experts?
Date: Fri, 11 Jan 2019 09:24:54 +0200 [thread overview]
Message-ID: <83pnt3hd15.fsf@gnu.org> (raw)
In-Reply-To: <871s5ktf9b.fsf@fastmail.fm> (message from Joost Kremers on Thu, 10 Jan 2019 21:43:44 +0100)
> From: Joost Kremers <joostkremers@fastmail.fm>
> Date: Thu, 10 Jan 2019 21:43:44 +0100
>
> The problem is that although full screen is activated before
> calculating the text width, (window-total-width) still reports the
> window width that existed before full screen was activated. This
> seems to be some sort of race condition, because adding (sleep-for
> 2) before calling (window-total-width) solves the issue.
Does (sit-for 0) also solve the issue? If not, try values of argument
smaller than a second, starting from, say, 0.02, and see if some small
enough value resolves the problem.
> It seems that a call to (redisplay) also does the trick, but I'm
> hesitant to add this, because, well, I'm not sure why, exactly,
> it's just that I'm not entirely sure when, i.e., in what
> circumstances, (redisplay) is meant to be used, what side effects
> to watch out for (in any), etc.
There should be no problem with invoking 'redisplay', it just slows
down the program a bit, especially if the code in question will or
might be executed frequently. However, sit-for is IMO better, because
in some use cases you must allow for the window manager to respond to
the full-screen request and for Emacs to receive a notification from
the window manager. And that means waiting for some short time.
> So I guess what I'm asking is whether someone can tell me whether
> (redisplay) is the right way to deal with this issue, or whether
> there is a better way. Or perhaps the user is SOL and needs to do
> some local configuration to get things to behave?
I cannot answer this because it isn't clear to me who initiated
full-screen: the user or the package. If it's the package, then the
package should also accommodate these issues, perhaps only when the
frame size changes significantly.
next prev parent reply other threads:[~2019-01-11 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 20:43 Is it ok to use (redisplay), or should this be left to the experts? Joost Kremers
2019-01-10 22:02 ` Stefan Monnier
2019-02-11 23:27 ` Joost Kremers
2019-02-12 3:58 ` Stefan Monnier
2019-02-12 8:06 ` Joost Kremers
2019-02-12 14:45 ` Stefan Monnier
2019-01-11 7:24 ` Eli Zaretskii [this message]
2019-02-11 23:43 ` Joost Kremers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnt3hd15.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.