From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix `early-init-file' value when file is missing Date: Mon, 11 Feb 2019 18:05:32 +0200 Message-ID: <83pnryl38z.fsf@gnu.org> References: <8336p7zxdf.fsf@gnu.org> <83bm3mrazc.fsf@gnu.org> <837eeaosm9.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="264324"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Radon Rosborough Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 11 17:06:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gtE60-0016bF-Bn for ged-emacs-devel@m.gmane.org; Mon, 11 Feb 2019 17:06:12 +0100 Original-Received: from localhost ([127.0.0.1]:52203 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtE5z-0004Ij-BX for ged-emacs-devel@m.gmane.org; Mon, 11 Feb 2019 11:06:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtE5l-0004H1-4h for emacs-devel@gnu.org; Mon, 11 Feb 2019 11:05:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtE5h-0005Dw-M1; Mon, 11 Feb 2019 11:05:55 -0500 Original-Received: from [176.228.60.248] (port=4215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gtE5a-0004Sg-Ql; Mon, 11 Feb 2019 11:05:51 -0500 In-reply-to: (message from Radon Rosborough on Sun, 10 Feb 2019 15:04:59 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233221 Archived-At: > From: Radon Rosborough > Date: Sun, 10 Feb 2019 15:04:59 -0800 > Cc: emacs-devel > > > you've modified the API of load-user-init-file > > But we have never released a version of Emacs that includes this > function -- and it's an internal function. There are only two callers > of this function that exist, and they are both touched by this patch. True, but that's not what bothered me. What bothered me was that changes in the interface and the implementation of the function might adversely affect the other caller of this function in startup.el, and verifying that no use case will become broken because of that is not a trivial task. For a significant improvement ion functionality, such risks might be justified, but here we are talking about a minor cleanup, so I'd prefer a safer change. > > Or do that inside the function, but only if it processes early-init > > file specifically? > > I really thought that this was exactly what my patch did. There are > exactly two places where this internal function is called, and > checking whether the optional argument is provided is the way to tell > whether the early init-file is being processed. Such a test is too indirect, and will cease to DTRT if we ever need to pass a second function in the case of early-init or not pass it in the other case. I hope we can make a more direct test.