From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function Date: Thu, 04 Apr 2019 16:04:35 +0300 Message-ID: <83pnq1diqk.fsf@gnu.org> References: <83a7i15vrk.fsf@gnu.org> <787f765a-42f4-40d0-3b78-e751f546fe6c@yandex.ru> <831s3c3ta8.fsf@gnu.org> <8f7ae869-2e94-5535-f16f-476348036dc2@yandex.ru> <83r2bc2csd.fsf@gnu.org> <83h8c63ek1.fsf@gnu.org> <7240d82b-5919-cee8-e3bc-81be8d996400@yandex.ru> <83pnqsyw68.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138315"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34763@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 04 15:06:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hC24K-000Zkz-VD for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Apr 2019 15:06:13 +0200 Original-Received: from localhost ([127.0.0.1]:54202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC24J-0001sr-U8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Apr 2019 09:06:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC24B-0001qG-HS for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 09:06:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hC24A-0002tX-JL for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 09:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hC24A-0002sc-CL for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 09:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hC24A-0007Ul-55 for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2019 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2019 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34763 X-GNU-PR-Package: emacs Original-Received: via spool by 34763-submit@debbugs.gnu.org id=B34763.155438310428735 (code B ref 34763); Thu, 04 Apr 2019 13:06:02 +0000 Original-Received: (at 34763) by debbugs.gnu.org; 4 Apr 2019 13:05:04 +0000 Original-Received: from localhost ([127.0.0.1]:43784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC23E-0007TP-AS for submit@debbugs.gnu.org; Thu, 04 Apr 2019 09:05:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hC239-0007Sn-0z for 34763@debbugs.gnu.org; Thu, 04 Apr 2019 09:05:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hC233-00017w-0L; Thu, 04 Apr 2019 09:04:53 -0400 Original-Received: from [176.228.60.248] (port=1696 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hC232-0007DI-2c; Thu, 04 Apr 2019 09:04:52 -0400 In-reply-to: (message from Dmitry Gutov on Thu, 4 Apr 2019 02:37:49 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157162 Archived-At: > Cc: 34763@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Apr 2019 02:37:49 +0300 > > On 15.03.2019 17:49, Eli Zaretskii wrote: > > > The code in the functions that react to quit-flag being non-nil should > > be audited. They don't look clean to me, FWIW, and we don't generally > > do such things from Lisp, we normally quit on the C level. Maybe this > > whole sub-feature, whereby we show a message for interrupted > > transfers, should be rethought. > > Apparently the idea is to handle quits, including contexts where > inhibit-quit is t (947612be2c71d2478179694e8dfa538b9e8e07c1). > > So url-retrieve-synchronously uses with-local-quit around > accept-process-output, and I guess the idea was to handle quits inside > debugging output calls. If that's the intent, why does it need to explicitly quit in Lisp? Just letting the code leave the form where inhibit-quit is non-nil will let Emacs quit at the first opportunity, with no need for any Lisp code for that.