From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sun, 07 Apr 2019 21:31:28 +0300 Message-ID: <83pnpx8y67.fsf@gnu.org> References: <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org> <20190406152014.zykyiakddmwsmkko@Ergus> <83a7h39l8l.fsf@gnu.org> <20190406185936.ndw74l5ysowmoihf@Ergus> <837ec79cme.fsf@gnu.org> <20190407181925.w3aztx44g5drtww2@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112176"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 07 20:31:46 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDCa1-000T4f-Gz for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 20:31:45 +0200 Original-Received: from localhost ([127.0.0.1]:42204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCa0-00066R-DN for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2019 14:31:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCZt-00064E-Qv for emacs-devel@gnu.org; Sun, 07 Apr 2019 14:31:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDCZr-0002jH-PE; Sun, 07 Apr 2019 14:31:35 -0400 Original-Received: from [176.228.60.248] (port=3826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hDCZq-00016I-VA; Sun, 07 Apr 2019 14:31:35 -0400 In-reply-to: <20190407181925.w3aztx44g5drtww2@Ergus> (message from Ergus on Sun, 7 Apr 2019 20:19:25 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235079 Archived-At: > Date: Sun, 7 Apr 2019 20:19:25 +0200 > From: Ergus > Cc: emacs-devel@gnu.org > > I have been testing all the latest changes with the display-fci-mode and > I have just found that the display-fill-column-indicator variable (and > the others) are not buffer local anymore after the latest changes. So I > cannot enable the mode for some buffers and not for others. > > As in display-line-numbers this works because there are still the > Fmake_variable_buffer_local (Qdisplay_line_numbers); I tested > customize-variable for display-line-numbers variables and it looks like > setting in that way doesn't work as it was happening to > display-fill-column-indicator yesterday. Sorry, I don't think I understand what you are saying here. I see that the display-fill-column-indicator variables aren't made buffer-local in xdisp.c; why not? Would doing that solve the problem? And what do you mean by "it looks like setting in that way doesn't work as it was happening to display-fill-column-indicator yesterday"? What did you try, and what didn't work? and why are you talking about display-line-numbers and display-fill-column-indicator intermittently? > If I set any of those with set-variable it works. So it is exactly the > same problem I had on yesterday. I thought yesterday's problem was that customize-variable didn't work at all. > So the problem seems to be somewhere else. Any suggestion? What problem are we talking about? I'm confused.