From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35464: [PATCH] Refactor update_window_begin and update_window_end hooks Date: Sun, 28 Apr 2019 21:45:37 +0300 Message-ID: <83pnp6t1da.fsf@gnu.org> References: <87k1ffnnn2.fsf@gmail.com> <83v9yyt6xp.fsf@gnu.org> <87zhoanfh3.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187955"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35464@debbugs.gnu.org To: Alex Gramiak Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 28 20:47:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKopS-000mjV-93 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Apr 2019 20:47:10 +0200 Original-Received: from localhost ([127.0.0.1]:47401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKopR-0005yl-6j for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Apr 2019 14:47:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKopK-0005yb-PI for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 14:47:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKopJ-0001yI-QG for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 14:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52490) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKopJ-0001y5-Lz for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 14:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hKopJ-0000d2-Hi for bug-gnu-emacs@gnu.org; Sun, 28 Apr 2019 14:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Apr 2019 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35464-submit@debbugs.gnu.org id=B35464.15564771702351 (code B ref 35464); Sun, 28 Apr 2019 18:47:01 +0000 Original-Received: (at 35464) by debbugs.gnu.org; 28 Apr 2019 18:46:10 +0000 Original-Received: from localhost ([127.0.0.1]:37801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKooU-0000bq-6c for submit@debbugs.gnu.org; Sun, 28 Apr 2019 14:46:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKooT-0000bf-74 for 35464@debbugs.gnu.org; Sun, 28 Apr 2019 14:46:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKooN-0001Qt-TA; Sun, 28 Apr 2019 14:46:03 -0400 Original-Received: from [176.228.60.248] (port=1582 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hKooM-0005ZE-83; Sun, 28 Apr 2019 14:46:03 -0400 In-reply-to: <87zhoanfh3.fsf@gmail.com> (message from Alex Gramiak on Sun, 28 Apr 2019 12:37:28 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158402 Archived-At: > From: Alex Gramiak > Cc: 35464@debbugs.gnu.org > Date: Sun, 28 Apr 2019 12:37:28 -0600 > > > Also, please don't add gui_* functions extracted from the *term.c > > files in xdisp.c, as that file is already too large. Renaming > > existing functions in xdisp.c is OK, as well as adding static utility > > functions. But for new gui_* functions that were originally in > > xterm.c etc., I'd prefer a new file, let's call it gui_term.c. > > A gui_term.c might be beneficial in the future, but I'm not sure it > should be the place for RIF procedures like these. Bu these functions are not RIF procedures, they are just regular functions. > I attached an updated patch that currently puts them in terminal.c > (beside update_begin and update_end), but I think a better place > would be to put them beside update_window in dispnew.c. WDYT? It isn't worth arguing about 2 short functions, so OK. But those in your other patch should definitely start a new file.