From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Line height issues with display-line-number-mode Date: Tue, 07 May 2019 22:43:59 +0300 Message-ID: <83pnouhwxs.fsf@gnu.org> References: <6fd496f0-7dd5-6c0e-5121-b618e7dca831@gmail.com> <83sgtqi02k.fsf@gnu.org> <83r29ahyz2.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205817"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 21:45:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO61N-000rR7-Cs for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 21:45:01 +0200 Original-Received: from localhost ([127.0.0.1]:52129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO61M-0002DB-5B for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 15:45:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO60m-00025c-AL for emacs-devel@gnu.org; Tue, 07 May 2019 15:44:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO60m-00062f-5e; Tue, 07 May 2019 15:44:24 -0400 Original-Received: from [176.228.60.248] (port=4027 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hO60j-00046l-J7; Tue, 07 May 2019 15:44:23 -0400 In-reply-to: (message from Stefan Monnier on Tue, 07 May 2019 15:09:23 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236258 Archived-At: > From: Stefan Monnier > Date: Tue, 07 May 2019 15:09:23 -0400 > > Rather than try and guess it based on the presence of a display/overlay, > maybe we could require a specific text-property like `no-line-number`? We already have such a text property (display-line-number-disable), but it cannot help here, because you do want the line of buffer text that follows the after-string to have a number. Only the after-string should not have a number. > BTW: in nlinum-mode (and presumably linum-mode as well), the > line-numbers are clipped, so I guess this is a difference between > text-in-the-margin and text-in-the-"main"-area. Those modes didn't pay attention to overlays at all. Anyway, people are welcome to work on some tweak in these cases. It's a bit tricky, because the display engine only ever looks at a single screen line, but maybe someone will have a clever idea.