Re: scratch/X_Typedefs 09c65d6 5/7: Introduce Emacs_GC struct and typedef

[Eli Zaretskii <eliz@gnu.org>]

> From: Alex Gramiak <agrambot@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 14 May 2019 13:48:09 -0600
> 
> >   CC       dispnew.o
> > In file included from dispnew.c:48:0:
> > w32term.h:371:3: error: unknown type name 'Cursor'
> >    Cursor current_cursor;
> >    ^~~~~~
> > [...]
> 
> Whoops, I forgot about that lonesome cursor. I pushed a fix for that.

Thanks, it builds now.

Regarding the patch, I have only one comment:

> @@ -1289,7 +1317,7 @@ struct glyph_string
>    enum glyph_row_area area;
> 
>    /* Characters to be drawn, and number of characters.  */
> -  XChar2b *char2b;
> +  unsigned short *char2b;
>    int nchars;

Why use 'unsigned short' and not 'unsigned int'?  The latter is more
efficient on modern architectures, and in structures you will likely
have the compiler pad the following 16 bits anyway.