From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/X_Typedefs 09c65d6 5/7: Introduce Emacs_GC struct and typedef
Date: Wed, 15 May 2019 19:22:14 +0300 [thread overview]
Message-ID: <83pnoj8z7t.fsf@gnu.org> (raw)
In-Reply-To: <87bm04hl6u.fsf@gmail.com> (message from Alex Gramiak on Tue, 14 May 2019 13:48:09 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 14 May 2019 13:48:09 -0600
>
> > CC dispnew.o
> > In file included from dispnew.c:48:0:
> > w32term.h:371:3: error: unknown type name 'Cursor'
> > Cursor current_cursor;
> > ^~~~~~
> > [...]
>
> Whoops, I forgot about that lonesome cursor. I pushed a fix for that.
Thanks, it builds now.
Regarding the patch, I have only one comment:
> @@ -1289,7 +1317,7 @@ struct glyph_string
> enum glyph_row_area area;
>
> /* Characters to be drawn, and number of characters. */
> - XChar2b *char2b;
> + unsigned short *char2b;
> int nchars;
Why use 'unsigned short' and not 'unsigned int'? The latter is more
efficient on modern architectures, and in structures you will likely
have the compiler pad the following 16 bits anyway.
next prev parent reply other threads:[~2019-05-15 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190513175241.9359.28585@vcs0.savannah.gnu.org>
[not found] ` <20190513175245.1B38320664@vcs0.savannah.gnu.org>
2019-05-14 8:07 ` scratch/X_Typedefs 09c65d6 5/7: Introduce Emacs_GC struct and typedef Robert Pluim
2019-05-14 15:13 ` Alex Gramiak
2019-05-14 15:32 ` Robert Pluim
2019-05-14 15:51 ` Alex Gramiak
2019-05-14 15:58 ` Robert Pluim
2019-05-14 16:11 ` Alex Gramiak
2019-05-14 18:47 ` Eli Zaretskii
2019-05-14 19:43 ` Stefan Monnier
2019-05-14 20:02 ` Alex Gramiak
2019-05-14 19:48 ` Alex Gramiak
2019-05-15 16:22 ` Eli Zaretskii [this message]
2019-05-15 18:59 ` Alex Gramiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnoj8z7t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.