From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Tue, 28 May 2019 21:51:18 +0300 Message-ID: <83pno2za3d.fsf@gnu.org> References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> <83v9xv2649.fsf@gnu.org> <83imtv1fbf.fsf@gnu.org> <7F0B61E6-C0CA-449B-B432-095569589168@gnu.org> <83y32qzk9b.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9084"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 28 20:52:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVhCv-00026Q-8n for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 20:52:21 +0200 Original-Received: from localhost ([127.0.0.1]:41077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVhCt-0000OZ-TK for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 14:52:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVhBo-0000Nu-Sn for emacs-devel@gnu.org; Tue, 28 May 2019 14:51:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVhBo-0006iH-2d; Tue, 28 May 2019 14:51:12 -0400 Original-Received: from [176.228.60.248] (port=4910 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hVhBn-00045G-Ap; Tue, 28 May 2019 14:51:11 -0400 In-reply-to: (message from Stefan Monnier on Tue, 28 May 2019 13:25:17 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237121 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Tue, 28 May 2019 13:25:17 -0400 > > > OK, but how does this affect the issue at hand? We want to replace > > string-as-unibyte, or remove it, and the obsolescence message says to > > replace it with encode-coding-string. > > But this obsolescence message assumes that the call to string-as-unibyte > was used because of a need to encode the strings using Emacs's internal > coding-system. In this case, the string is already encoded (as stated > by the function's name, the docstring, ...), so using > encode-coding-string is rather odd. If the input string is unibyte, then using string-to-unibyte will be also odd. And if it's multibyte, the using encode-coding-string is not really odd, is it? > I agree that removing the call altogether is the better option. Right. In that case we need to document that the function expects as input either a unibyte string or a pure-ASCII string.