From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35967: [PATCH] avoid flyspell error if point is at bob Date: Wed, 29 May 2019 19:08:18 +0300 Message-ID: <83pno1xmz1.fsf@gnu.org> References: <87h89e8g3a.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="80205"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35967@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 29 18:09:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW18b-000KkS-1H for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 May 2019 18:09:13 +0200 Original-Received: from localhost ([127.0.0.1]:57413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW18Z-0002Bv-Ut for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 May 2019 12:09:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW18R-0002B1-Hh for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 12:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hW18Q-0002OE-K4 for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 12:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hW18Q-0002O9-GM for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 12:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hW18Q-0000x6-B3 for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 May 2019 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35967-submit@debbugs.gnu.org id=B35967.15591461033606 (code B ref 35967); Wed, 29 May 2019 16:09:02 +0000 Original-Received: (at 35967) by debbugs.gnu.org; 29 May 2019 16:08:23 +0000 Original-Received: from localhost ([127.0.0.1]:59672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW17m-0000w6-Vs for submit@debbugs.gnu.org; Wed, 29 May 2019 12:08:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW17l-0000vn-E5 for 35967@debbugs.gnu.org; Wed, 29 May 2019 12:08:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW17d-00022T-4F; Wed, 29 May 2019 12:08:15 -0400 Original-Received: from [176.228.60.248] (port=3952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hW17Z-0004fI-CH; Wed, 29 May 2019 12:08:09 -0400 In-reply-to: <87h89e8g3a.fsf@gmail.com> (message from Alex Branham on Tue, 28 May 2019 15:43:53 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159884 Archived-At: > From: Alex Branham > Date: Tue, 28 May 2019 15:43:53 -0500 > > >From e130dfcb542af667fbef6e6eb867c46eee6d9746 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Tue, 28 May 2019 15:40:26 -0500 > Subject: [PATCH] Avoid a flyspell error if point is at beginning of buffer > > * lisp/textmodes/flyspell.el (flyspell-generic-progmode-verify): > Check if point is at bob. This prevents an error when e.g. > 'flyspell-auto-correct-word' gets called with point at the > beginning of the buffer. > --- > lisp/textmodes/flyspell.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el > index d18916dfd0..e711fe72b2 100644 > --- a/lisp/textmodes/flyspell.el > +++ b/lisp/textmodes/flyspell.el > @@ -424,8 +424,9 @@ like \"Some." > (defun flyspell-generic-progmode-verify () > "Used for `flyspell-generic-check-word-predicate' in programming modes." > ;; (point) is next char after the word. Must check one char before. > - (let ((f (get-text-property (- (point) 1) 'face))) > - (memq f flyspell-prog-text-faces))) > + (unless (bobp) > + (let ((f (get-text-property (- (point) 1) 'face))) > + (memq f flyspell-prog-text-faces)))) Thanks. Maybe it's just me, but whenever I see bobp, I always have to consult the docs regarding what happens in a narrowed buffer. For that reason, I prefer comparison with point-min instead. Am I the only one troubled by that?