* Drop "experimental" status of --with-cairo ?
@ 2019-06-18 3:44 YAMAMOTO Mitsuharu
2019-06-18 12:26 ` Stefan Monnier
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: YAMAMOTO Mitsuharu @ 2019-06-18 3:44 UTC (permalink / raw)
To: emacs-devel
I think the cairo drawing code on master is now stable enough and
consistent with non-cairo X11 build. I suggest dropping
"experimental" status of the --with-cairo option. WDYT?
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 3:44 Drop "experimental" status of --with-cairo ? YAMAMOTO Mitsuharu
@ 2019-06-18 12:26 ` Stefan Monnier
2019-06-18 12:47 ` Robert Pluim
2019-06-18 16:52 ` Eli Zaretskii
2 siblings, 0 replies; 8+ messages in thread
From: Stefan Monnier @ 2019-06-18 12:26 UTC (permalink / raw)
To: emacs-devel
> I think the cairo drawing code on master is now stable enough and
> consistent with non-cairo X11 build. I suggest dropping
> "experimental" status of the --with-cairo option. WDYT?
Seeing all your coding efforts on it of late, I started to
compile --with-cairo last week and I didn't notice any negative
effect since then, so +1 from this user.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 3:44 Drop "experimental" status of --with-cairo ? YAMAMOTO Mitsuharu
2019-06-18 12:26 ` Stefan Monnier
@ 2019-06-18 12:47 ` Robert Pluim
2019-06-18 23:12 ` YAMAMOTO Mitsuharu
2019-06-18 16:52 ` Eli Zaretskii
2 siblings, 1 reply; 8+ messages in thread
From: Robert Pluim @ 2019-06-18 12:47 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: emacs-devel
>>>>> On Tue, 18 Jun 2019 12:44:21 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:
Mitsuharu> I think the cairo drawing code on master is now stable enough and
Mitsuharu> consistent with non-cairo X11 build. I suggest dropping
Mitsuharu> "experimental" status of the --with-cairo option. WDYT?
You mean setting --with-cairo to enabled by default? Sounds good to me
(but Iʼm by nature somewhat less than conservative with this kind of
stuff :-) )
Robert
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 3:44 Drop "experimental" status of --with-cairo ? YAMAMOTO Mitsuharu
2019-06-18 12:26 ` Stefan Monnier
2019-06-18 12:47 ` Robert Pluim
@ 2019-06-18 16:52 ` Eli Zaretskii
2019-06-18 19:44 ` Michael Albinus
2 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2019-06-18 16:52 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: emacs-devel
> Date: Tue, 18 Jun 2019 12:44:21 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>
> I think the cairo drawing code on master is now stable enough and
> consistent with non-cairo X11 build. I suggest dropping
> "experimental" status of the --with-cairo option. WDYT?
Are all the Cairo-related bugs in the debbugs database fixed?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 16:52 ` Eli Zaretskii
@ 2019-06-18 19:44 ` Michael Albinus
2019-06-18 20:56 ` Dmitry Gutov
0 siblings, 1 reply; 8+ messages in thread
From: Michael Albinus @ 2019-06-18 19:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: YAMAMOTO Mitsuharu, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Tue, 18 Jun 2019 12:44:21 +0900
>> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>>
>> I think the cairo drawing code on master is now stable enough and
>> consistent with non-cairo X11 build. I suggest dropping
>> "experimental" status of the --with-cairo option. WDYT?
>
> Are all the Cairo-related bugs in the debbugs database fixed?
A short search returns
--8<---------------cut here---------------start------------->8---
24144 normal,help [Michael Rose ] 25.1.50; cairo: window contents aren't resized when window is resized by creation/removal of windows in i3wm
23925 24310,normal,help [Roland Winkler ] 25.0.95; cairo: display broken when maximizing frames
21110 22442,normal,help [Robert Marshall ] cairo: Images viewed with Image[Imagemagick] mode are garbled
20997 minor,help [James Cloos ] display issues with cairo
--8<---------------cut here---------------end--------------->8---
There are also the following reports, but I'm not sure whether they are
really related to cairo
--8<---------------cut here---------------start------------->8---
34024 normal [Clément Pit-Claudel ] ImageMagick: Segfault when resizing SVG images
22503 normal [André Bjärby ] 25.0.90; maximizing frame doesn't redraw screen
14993 minor,patch [Xue Fuqiao ] [PATCH] Update information about fonts
--8<---------------cut here---------------end--------------->8---
Best regards, Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 19:44 ` Michael Albinus
@ 2019-06-18 20:56 ` Dmitry Gutov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Gutov @ 2019-06-18 20:56 UTC (permalink / raw)
To: Michael Albinus, Eli Zaretskii; +Cc: YAMAMOTO Mitsuharu, emacs-devel
On 18.06.2019 22:44, Michael Albinus wrote:
> A short search returns
>
> --8<---------------cut here---------------start------------->8---
> 24144 normal,help [Michael Rose ] 25.1.50; cairo: window contents aren't resized when window is resized by creation/removal of windows in i3wm
> 23925 24310,normal,help [Roland Winkler ] 25.0.95; cairo: display broken when maximizing frames
> 21110 22442,normal,help [Robert Marshall ] cairo: Images viewed with Image[Imagemagick] mode are garbled
> 20997 minor,help [James Cloos ] display issues with cairo
Looking at the age of the last comment in most of these, we might want
to do another round of "are you still seeing this problem".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 12:47 ` Robert Pluim
@ 2019-06-18 23:12 ` YAMAMOTO Mitsuharu
2019-06-19 7:10 ` Paul Eggert
0 siblings, 1 reply; 8+ messages in thread
From: YAMAMOTO Mitsuharu @ 2019-06-18 23:12 UTC (permalink / raw)
To: emacs-devel
On Tue, 18 Jun 2019 21:47:54 +0900,
Robert Pluim wrote:
>
> >>>>> On Tue, 18 Jun 2019 12:44:21 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:
>
> Mitsuharu> I think the cairo drawing code on master is now stable enough and
> Mitsuharu> consistent with non-cairo X11 build. I suggest dropping
> Mitsuharu> "experimental" status of the --with-cairo option. WDYT?
>
> You mean setting --with-cairo to enabled by default? Sounds good to me
> (but Iʼm by nature somewhat less than conservative with this kind of
> stuff :-) )
That would be the next step. For now, I suggest dropping the word
"(experimental)" from configure.ac, and encourage people (especially
those who previously tried --with-cairo but abandoned) to try it again
to iron out remaining issues.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Drop "experimental" status of --with-cairo ?
2019-06-18 23:12 ` YAMAMOTO Mitsuharu
@ 2019-06-19 7:10 ` Paul Eggert
0 siblings, 0 replies; 8+ messages in thread
From: Paul Eggert @ 2019-06-19 7:10 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: Emacs Development
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
YAMAMOTO Mitsuharu wrote:
> I suggest dropping the word
> "(experimental)" from configure.ac, and encourage people (especially
> those who previously tried --with-cairo but abandoned) to try it again
> to iron out remaining issues.
The first part's easy enough; I installed the attached. Thanks for working on this.
[-- Attachment #2: 0001-with-cairo-is-no-longer-experimental.patch --]
[-- Type: text/x-patch, Size: 1843 bytes --]
From 50c5d5621cb5e6d7c86829ac4b776d81e47b2189 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 19 Jun 2019 00:06:39 -0700
Subject: [PATCH] --with-cairo is no longer experimental
Suggested by YAMAMOTO Mitsuharu in:
https://lists.gnu.org/r/emacs-devel/2019-06/msg00686.html
* configure.ac: Do not say --with-cairo is experimental.
* etc/NEWS: Say that --with-cairo is no longer experimental.
---
configure.ac | 2 +-
etc/NEWS | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index a2e66c3f49..be5c4e35b1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -430,7 +430,7 @@ AC_DEFUN
OPTION_DEFAULT_ON([rsvg],[don't compile with SVG image support])
OPTION_DEFAULT_ON([lcms2],[don't compile with Little CMS support])
OPTION_DEFAULT_ON([libsystemd],[don't compile with libsystemd support])
-OPTION_DEFAULT_OFF([cairo],[compile with Cairo drawing (experimental)])
+OPTION_DEFAULT_OFF([cairo],[compile with Cairo drawing])
OPTION_DEFAULT_ON([xml2],[don't compile with XML parsing support])
OPTION_DEFAULT_OFF([imagemagick],[compile with ImageMagick image support])
OPTION_DEFAULT_ON([json], [don't compile with native JSON support])
diff --git a/etc/NEWS b/etc/NEWS
index 65dc095052..bf92a551a5 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -49,6 +49,10 @@ functions 'json-serialize', 'json-insert', 'json-parse-string', and
'json-parse-buffer' are typically much faster than their Lisp
counterparts from json.el.
+** The configure option --with-cairo is no longer experimental.
+This builds Emacs with Cairo drawing, and supports built-in printing
+when Emacs is built with GTK+.
+
** Emacs no longer defaults to using ImageMagick to display images,
due to security and stability concerns. To override the default, use
'configure --with-imagemagick'.
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-19 7:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-18 3:44 Drop "experimental" status of --with-cairo ? YAMAMOTO Mitsuharu
2019-06-18 12:26 ` Stefan Monnier
2019-06-18 12:47 ` Robert Pluim
2019-06-18 23:12 ` YAMAMOTO Mitsuharu
2019-06-19 7:10 ` Paul Eggert
2019-06-18 16:52 ` Eli Zaretskii
2019-06-18 19:44 ` Michael Albinus
2019-06-18 20:56 ` Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.