all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Damien Cassou <damien@cassou.me>
Cc: magnus.henoch@gmail.com, nicolas@petton.fr, npostavs@gmail.com,
	iku.iwasa@gmail.com, camalot@picnicpark.org,
	gaby.launay@tutanota.com, 36052@debbugs.gnu.org,
	tzz@lifelogs.com
Subject: bug#36052: 26.2.50; [PATCH] Improve auth-source-pass
Date: Sat, 22 Jun 2019 12:02:52 +0300	[thread overview]
Message-ID: <83pnn6ngar.fsf@gnu.org> (raw)
In-Reply-To: <87imt8ywfy.fsf@cassou.me> (message from Damien Cassou on Fri, 14 Jun 2019 18:16:01 +0200)

> From: Damien Cassou <damien@cassou.me>
> Cc: 36052@debbugs.gnu.org, npostavs@gmail.com, magnus.henoch@gmail.com, tzz@lifelogs.com, iku.iwasa@gmail.com, camalot@picnicpark.org, gaby.launay@tutanota.com, nicolas@petton.fr
> Date: Fri, 14 Jun 2019 18:16:01 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> > These are all described in the patch for the manual, right?  If so,
> > the entries should be marked with "+++", see the beginning of NEWS for
> > instructions about that.
> 
> 
> I'm not sure which patch you reviewed so I attach it again to this new
> email. The first 2 items in NEWS (new user options) are covered by the
> manual so I've added '+++' in front of each. The last 2 items (less
> decryption and autoload) shouldn't be in the manual so I've added '---'
> in front of each.
> 
> 
> > Please make the text describing each @item start on a new line.  Also,
> > it sounds like you want @table here, not @itemize.  And finally,
> > quoting in @code is sub-optimal; would @samp (and losing the quotes)
> > do the job?
> >
> > File names or their parts should have the @file markup, not @code.
> 
> I'm not sure I did it right, but you will find a new patch attached to
> this email.

Thanks, these LGTM.





  reply	other threads:[~2019-06-22  9:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02  9:11 bug#36052: 26.2.50; [PATCH] Improve auth-source-pass Damien Cassou
2019-06-07  0:43 ` Noam Postavsky
2019-06-08 15:47   ` Damien Cassou
2019-06-08 16:02     ` Eli Zaretskii
2019-06-08 22:38     ` Noam Postavsky
2019-06-13 19:59     ` Damien Cassou
2019-06-13 21:23       ` Noam Postavsky
2019-06-14  7:10       ` Damien Cassou
2019-06-14  7:47       ` Eli Zaretskii
2019-06-14 16:16         ` Damien Cassou
2019-06-22  9:02           ` Eli Zaretskii [this message]
2019-06-24  7:26             ` Damien Cassou
2019-06-24 14:33               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pnn6ngar.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36052@debbugs.gnu.org \
    --cc=camalot@picnicpark.org \
    --cc=damien@cassou.me \
    --cc=gaby.launay@tutanota.com \
    --cc=iku.iwasa@gmail.com \
    --cc=magnus.henoch@gmail.com \
    --cc=nicolas@petton.fr \
    --cc=npostavs@gmail.com \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.