From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: `message' not outputting the newline "atomically" Date: Tue, 25 Jun 2019 19:06:12 +0300 Message-ID: <83pnn1lkej.fsf@gnu.org> References: <07619925-e367-fb88-2dd8-27addb2e9052@grinta.net> <68b398b1-3790-b32f-535d-6ea2518f79b8@cs.ucla.edu> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250740"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, daniele@grinta.net, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 18:25:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfoFo-00134c-Av for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2019 18:25:08 +0200 Original-Received: from localhost ([::1]:33824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfoFn-00006U-Co for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2019 12:25:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41635) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfnxW-0004Po-8V for emacs-devel@gnu.org; Tue, 25 Jun 2019 12:06:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfnxV-0006m4-Gk; Tue, 25 Jun 2019 12:06:14 -0400 Original-Received: from [176.228.60.248] (port=1500 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hfnxU-0004DR-Qz; Tue, 25 Jun 2019 12:06:13 -0400 In-reply-to: <68b398b1-3790-b32f-535d-6ea2518f79b8@cs.ucla.edu> (message from Paul Eggert on Mon, 24 Jun 2019 15:03:01 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238141 Archived-At: > From: Paul Eggert > Date: Mon, 24 Jun 2019 15:03:01 -0700 > Cc: Daniele Nicolodi , emacs-devel@gnu.org > > On 6/24/19 2:33 PM, Lars Ingebrigtsen wrote: > > the code also calls code_convert_string, so I thought one > > more xmalloc didn't make much difference. > > If code_convert_string could cause an infloop when reporting > low-on-memory messages, then we should fix that infloop too. In the > meantime we shouldn't make things worse by doing yet another heap > allocation. It is very unusual for code_convert_string to allocate memory; normally it just reuses a buffer that was allocated at startup. So I think we don't normally have any heap allocations in this use case -- or didn't have until now. I agree that we should avoid that.