From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Mon, 19 Aug 2019 19:50:36 +0300 Message-ID: <83pnl1kskj.fsf@gnu.org> References: <831rxqtnaf.fsf@gnu.org> <7ba80ec4-d7e2-1f69-5b55-00a8c1851cb4@gmx.at> <83k1bhrsji.fsf@gnu.org> <6f3161f8-b007-ae1c-881e-1fad88348146@gmx.at> <83woffrd7p.fsf@gnu.org> <8336i2qwxj.fsf@gnu.org> <020947f5-a8ab-79de-cf74-9dce4cb1572e@gmx.at> <838srtpkyp.fsf@gnu.org> <471528b0-4749-1dee-3be1-fa18a0203cc7@gmx.at> <20190819161305.uwlgsm44yjrmul3o@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="129942"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 18:51:06 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzks5-000XeH-EE for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2019 18:51:05 +0200 Original-Received: from localhost ([::1]:55640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzks4-0008Ey-8P for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2019 12:51:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42906) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzkrc-0008En-7Z for emacs-devel@gnu.org; Mon, 19 Aug 2019 12:50:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzkrb-0005tj-Ka; Mon, 19 Aug 2019 12:50:35 -0400 Original-Received: from [176.228.60.248] (port=1492 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzkrb-0007c2-0n; Mon, 19 Aug 2019 12:50:35 -0400 In-reply-to: <20190819161305.uwlgsm44yjrmul3o@Ergus> (message from Ergus on Mon, 19 Aug 2019 18:13:05 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239464 Archived-At: > Date: Mon, 19 Aug 2019 18:13:05 +0200 > From: Ergus > Cc: Eli Zaretskii , emacs-devel@gnu.org > > Extending the face is a detail that most users won't even notice a > change while it works somehow. Actually we have had different behaviors > between gui and tui for years and nobody complained up to now. I think you over-simplify the situation. First, both GUI and TTY frames behave the same when extension of face background color is concerned, they only differ in how they handle extension of other attributes (of which only the underline is relevant to TTY frames). (And I did hear over the years a couple of complaints about how TTY frames extend the underline attribute.) And second, I refer you to the renewed discussion of bug#15934 a day or two ago, from which my take is that users will notice and do care about such changes in at least a couple of important use cases, as a soon-to-be-pushed changes will prove. So I don't think we can change this behavior at will on the assumption that "no one will notice". > I am wondering about over-specifications and over-engineering for such a > detail, when most of the users only need to extend the background color. This discussion established that even supporting just the background color non-extension as a user option will require to have almost all of the machinery in place: the extend bit, the generation of a special face without the background color, etc. And once we have that, adding other face attributes to the soup is relatively easy and won't require any design changes.