From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: [Emacs-diffs] master a59839d: file-truename now uses realpath for local files
Date: Sat, 07 Sep 2019 10:27:05 +0300 [thread overview]
Message-ID: <83pnkc5zxy.fsf@gnu.org> (raw)
Paul,
I had to revert this commit, as it had multiple issues:
. It breaks the MS-Windows build, because there's no realpath (and we
cannot use the Gnulib replacement, due to non-ASCII file names
Gnulib doesn't support well on Windows).
. Even when I modified file--truename to always signal an error on
MS-Windows, Emacs wouldn't build, probably because the
corresponding change in files.el has another mistake. Did you test
the build when realpath signals an error?
. I don't think it's a good idea to favor GNU/Linux systems by
punishing the rest. We should have a better way than signaling an
error on platforms where realpath doesn't work well enough. And in
any case, using Gnulib's realpath will not make file-truename
faster on those other systems.
. The code of file--truename incorrectly looked for the trailing
slash ion the encoded file name, something you can only do reliably
if the file-name encoding is UTF-8, because other encodings don't
guarantee a single slash is never part of a multibyte sequence.
. Last, but not least: there was no documentation of the new
primitive.
For all of these reasons, I think we need to talk about the issue
before implementing it, and the implementation, if we will have one,
should resolve all of the problems mentioned above.
next reply other threads:[~2019-09-07 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 7:27 Eli Zaretskii [this message]
2019-09-07 8:02 ` [Emacs-diffs] master a59839d: file-truename now uses realpath for local files Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnkc5zxy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.