From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Tue, 15 Oct 2019 10:55:45 +0300 Message-ID: <83pniyh27y.fsf@gnu.org> References: <990000647.207452.1567431109138@mail1.libero.it> <871rwy8osi.fsf@mail.linkov.net> <1202539102.243582.1567500548055@mail1.libero.it> <87h85t41cl.fsf@mail.linkov.net> <1215808011.309641.1567585329369@mail1.libero.it> <87k1answzi.fsf@mail.linkov.net> <1448946011.413994.1567719646039@mail1.libero.it> <8736h6v8v8.fsf@mail.linkov.net> <1255500419.255917.1568620575342@mail1.libero.it> <815541529.259638.1568623550774@mail1.libero.it> <87d0g00y61.fsf@mail.linkov.net> <1974399400.832770.1570978188863@mail1.libero.it> <83eezglm4r.fsf@gnu.org> <87zhi48fig.fsf@mail.linkov.net> <83tv8bkf3g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160427"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: juri@linkov.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 15 09:56:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKHh8-000fbr-TX for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 09:56:39 +0200 Original-Received: from localhost ([::1]:36519 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKHh7-0003Zf-II for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 03:56:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52472) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKHgN-0002qO-6v for emacs-devel@gnu.org; Tue, 15 Oct 2019 03:55:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKHgM-00069P-KV; Tue, 15 Oct 2019 03:55:50 -0400 Original-Received: from [176.228.60.248] (port=3264 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKHgL-00023I-H2; Tue, 15 Oct 2019 03:55:50 -0400 In-reply-to: <83tv8bkf3g.fsf@gnu.org> (message from Eli Zaretskii on Mon, 14 Oct 2019 09:37:07 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241035 Archived-At: > Date: Mon, 14 Oct 2019 09:37:07 +0300 > From: Eli Zaretskii > Cc: angelo.g0@libero.it, emacs-devel@gnu.org > > > The problem is that tab-bar.el is pre-loaded by loadup.el and > > dumped with the value of data-directory from the source location. > > So running from the dump file even in the install directory > > still uses source data-directory. > > Why can't you compute the value at run time, rather than at dump time? > Like the first time the tab bar is activated? I see that you have done so, thanks. However, there should be no need to explicitly expand-file-name for the image files, as the documentation of the :file attribute says: ‘:file FILE’ This says to load the image from file FILE. If FILE is not an absolute file name, it is expanded relative to the ‘images’ subdirectory of ‘data-directory’, and failing that, relative to the directories listed by ‘x-bitmap-file-path’ (*note Face Attributes::). So by explicitly calling expand-file-name, you introduce a subtle misfeature, whereby x-bitmap-file-path will not be consulted.