From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Should `revert-buffer' preserve text-scaling by default? Date: Fri, 29 Nov 2019 22:39:49 +0200 Message-ID: <83pnhao1re.fsf@gnu.org> References: <87fti6toq7.fsf@red-bean.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="209513"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 29 21:40:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ian3h-000sJE-SG for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2019 21:40:10 +0100 Original-Received: from localhost ([::1]:35058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ian3f-0002Fa-UU for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2019 15:40:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34058) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ian3I-0002F7-ES for emacs-devel@gnu.org; Fri, 29 Nov 2019 15:39:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ian3D-0003w0-7S; Fri, 29 Nov 2019 15:39:39 -0500 Original-Received: from [176.228.60.248] (port=3623 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ian3A-0007yx-B0; Fri, 29 Nov 2019 15:39:37 -0500 In-reply-to: <87fti6toq7.fsf@red-bean.com> (message from Karl Fogel on Fri, 29 Nov 2019 14:24:14 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242895 Archived-At: > From: Karl Fogel > Date: Fri, 29 Nov 2019 14:24:14 -0600 > > Before I go down this road, I'd like to know if anyone thinks text-scaling is just another minor mode and should be bound together with other modes via the existing `preserve-modes' flag to `revert-buffer'. I think the opposite: that is, I think text-scaling should be treated specially, for the reasons given above. I just wanted to check here before writing any code. There are other buffer-local minor modes that are of similar nature: display-line-numbers-mode, display-fill-column-indicator-mode, and maybe some others (e.g., what about hl-line-mode?). So if we are going to preserve text-scale-mode across reverting, I think we should have a list of modes to preserve, not just exempt this one mode.