From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes Date: Thu, 05 Dec 2019 21:25:14 +0200 Message-ID: <83pnh2h8x1.fsf@gnu.org> References: <20191130143638.GA6716@ACM> <20191201150738.GB5085@ACM> <83imn0lyed.fsf@gnu.org> <20191201192709.GE5085@ACM> <83blsrn58a.fsf@gnu.org> <20191204204159.GA7587@ACM> <83immuj0g7.fsf@gnu.org> <20191205190951.GA6252@ACM> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148700"; mail-complaints-to="usenet@blaine.gmane.org" Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 20:27:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icwmQ-000cVf-5F for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 20:27:14 +0100 Original-Received: from localhost ([::1]:60128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icwmO-0004WA-TI for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 14:27:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38433) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icwlK-0003vn-Oj for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 14:26:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icwlG-000799-Iw for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 14:26:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icwlF-00078J-Oi for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 14:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icwlF-0001Zj-L7 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 14:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38406 X-GNU-PR-Package: emacs Original-Received: via spool by 38406-submit@debbugs.gnu.org id=B38406.15755739386022 (code B ref 38406); Thu, 05 Dec 2019 19:26:01 +0000 Original-Received: (at 38406) by debbugs.gnu.org; 5 Dec 2019 19:25:38 +0000 Original-Received: from localhost ([127.0.0.1]:45230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icwks-0001Z3-0y for submit@debbugs.gnu.org; Thu, 05 Dec 2019 14:25:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icwkq-0001Ys-LT for 38406@debbugs.gnu.org; Thu, 05 Dec 2019 14:25:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1icwkg-0005dN-GA; Thu, 05 Dec 2019 14:25:27 -0500 Original-Received: from [176.228.60.248] (port=3747 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1icwkb-0006wo-8j; Thu, 05 Dec 2019 14:25:25 -0500 In-reply-to: <20191205190951.GA6252@ACM> (message from Alan Mackenzie on Thu, 5 Dec 2019 19:09:51 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172929 Archived-At: > Date: Thu, 5 Dec 2019 19:09:51 +0000 > Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org > From: Alan Mackenzie > > > Can you explain why you exempt these from being called from CC Mode? > > There is already a call to the matching-paren blink functionality in > cc-cmds.el, which must stay for older Emacsen. If blink-paren-p-s-i-f > was allowed to run too, the result would probably be a doubling of the > blink time. This is not desirable. The same applies to smie-blink-m-o, > which in any case will not be used for CC Mode. > > electric-pair-post-self-insert-function must not run in > c-electric-brace/paren except as carefully coded in these functions > explicitly; it would otherwise foul things up, one way or another, as it > did in the scenario for which bug #33794 was raised. > > Of the other three electric-* functions, only one has a complete doc > string, so it is work to work out what the other two do. > electric-indent-post-self-insert-function is redundant in CC Mode, and > probably harmful. At best it will just take up processor cycles. I > believe electric-layout-p-s-i-f just duplicates the auto-newline > behaviour of the c-electric-* functions, making it redundant. I don't > know exactly what electric-quote-p-s-i-f does, but it is likely to be > something to do with quotes, and thus likely to clash with CC Mode's > handling of quotes. I don't think CC Mode should protect users of those hooks from themselves. If the user or Lisp set up these hooks such that they end up shooting themselves in the foot, we should let them. We never provide any "safety nets" for silly hook functions, so we shouldn't do that here as well. OTOH, if someone puts a function on those hooks which does something legitimate, we should meet their expectations and let those functions run, as the contract says. So I think you shouldn't filter anything from the hook before you run it.