From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5ee43ba0df causing display hangs? Date: Sat, 07 Dec 2019 20:14:06 +0200 Message-ID: <83pnh0dmvl.fsf@gnu.org> References: <87k178gu5g.fsf@wavexx.thregr.org> <83sglwdoc0.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170186"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: wavexx@thregr.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 07 19:14:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idebF-000i8L-El for ged-emacs-devel@m.gmane.org; Sat, 07 Dec 2019 19:14:37 +0100 Original-Received: from localhost ([::1]:52176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idebD-0007Xa-Pz for ged-emacs-devel@m.gmane.org; Sat, 07 Dec 2019 13:14:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35061) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ideb8-0007XL-5I for emacs-devel@gnu.org; Sat, 07 Dec 2019 13:14:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ideb7-0000Id-Ns; Sat, 07 Dec 2019 13:14:29 -0500 Original-Received: from [176.228.60.248] (port=3839 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ideb6-00084Z-RW; Sat, 07 Dec 2019 13:14:29 -0500 In-reply-to: <83sglwdoc0.fsf@gnu.org> (message from Eli Zaretskii on Sat, 07 Dec 2019 19:42:39 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243218 Archived-At: > Date: Sat, 07 Dec 2019 19:42:39 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > I briefly noticed commit 5ee43ba0dfd96e5d39da556260346bd3c8ff99c1 > > (identified by bysecting) causes some modes to hang forever during > > display (mu4e-view-mode and the underlying gnus-article-mode), with C-g > > being ignored. > > The smallest self-contained recipe for reproducing the problem will be > appreciated. A stab in the dark: does the below fix the problem? diff --git a/src/xfaces.c b/src/xfaces.c index 6db4dcd..a2fbed8 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -2168,7 +2168,7 @@ face_inherited_attr (struct window *w, struct frame *f, if (CONSP (parent_face)) { Lisp_Object tail; - for (tail = parent_face; !NILP (tail); tail = XCDR (tail)) + for (tail = parent_face; CONSP (tail); tail = XCDR (tail)) { ok = get_lface_attributes (w, f, XCAR (tail), inherited_attrs, false, named_merge_points);