From: Eli Zaretskii <eliz@gnu.org>
To: wavexx@thregr.org
Cc: emacs-devel@gnu.org
Subject: Re: master 5ee43ba0df causing display hangs?
Date: Sat, 07 Dec 2019 20:14:06 +0200 [thread overview]
Message-ID: <83pnh0dmvl.fsf@gnu.org> (raw)
In-Reply-To: <83sglwdoc0.fsf@gnu.org> (message from Eli Zaretskii on Sat, 07 Dec 2019 19:42:39 +0200)
> Date: Sat, 07 Dec 2019 19:42:39 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> > I briefly noticed commit 5ee43ba0dfd96e5d39da556260346bd3c8ff99c1
> > (identified by bysecting) causes some modes to hang forever during
> > display (mu4e-view-mode and the underlying gnus-article-mode), with C-g
> > being ignored.
>
> The smallest self-contained recipe for reproducing the problem will be
> appreciated.
A stab in the dark: does the below fix the problem?
diff --git a/src/xfaces.c b/src/xfaces.c
index 6db4dcd..a2fbed8 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -2168,7 +2168,7 @@ face_inherited_attr (struct window *w, struct frame *f,
if (CONSP (parent_face))
{
Lisp_Object tail;
- for (tail = parent_face; !NILP (tail); tail = XCDR (tail))
+ for (tail = parent_face; CONSP (tail); tail = XCDR (tail))
{
ok = get_lface_attributes (w, f, XCAR (tail), inherited_attrs,
false, named_merge_points);
next prev parent reply other threads:[~2019-12-07 18:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 13:08 master 5ee43ba0df causing display hangs? Yuri D'Elia
2019-12-07 17:42 ` Eli Zaretskii
2019-12-07 18:14 ` Eli Zaretskii [this message]
2019-12-07 18:56 ` Yuri D'Elia
2019-12-07 19:18 ` Eli Zaretskii
2019-12-07 23:03 ` Yuri D'Elia
2019-12-08 15:55 ` Eli Zaretskii
2019-12-08 16:03 ` Yuri D'Elia
2019-12-08 16:57 ` Eli Zaretskii
2019-12-10 10:57 ` Yuri D'Elia
2019-12-10 12:01 ` Eli Zaretskii
2019-12-11 11:36 ` Yuri D'Elia
2019-12-11 17:14 ` Eli Zaretskii
2019-12-11 17:29 ` Yuri D'Elia
2019-12-11 17:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnh0dmvl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=wavexx@thregr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.