all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 39178-done@debbugs.gnu.org
Subject: bug#39178: 27.0.50; [PATCH] Fix: gdb-mi cannot recover from handler function error
Date: Fri, 31 Jan 2020 11:44:32 +0200	[thread overview]
Message-ID: <83pnf0klj3.fsf@gnu.org> (raw)
In-Reply-To: <6B1002BC-A735-4031-BD08-9647C062D2A2@gmail.com> (message from Yuan Fu on Sat, 18 Jan 2020 13:48:45 -0500)

> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 18 Jan 2020 13:48:45 -0500
> 
> If a handler produces an error, cleanup code doesn’t get to run and leaves gbd-mi.el in a corrupted state (in terms of communication buffer). So other handlers can’t parse the message sent from gdb anymore.

Thanks, pushed to the emacs-27 branch.

Please in the future try to observe the following nits:

> * lisp/progmodes/gdb-mi.el (gdb-handle-reply):
> Handle error in ’handler-function’ so the cleanup code after it

Please use quoting 'like this' in log messages (and also in NEWS).

> +      (condition-case err
> +          ;; protect against errors in handler-function

Comments should be complete sentences, and as such, begin with a
capital letter and end in a period.

(I fixed all of these nits this time.)





  reply	other threads:[~2020-01-31  9:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 18:48 bug#39178: 27.0.50; [PATCH] Fix: gdb-mi cannot recover from handler function error Yuan Fu
2020-01-31  9:44 ` Eli Zaretskii [this message]
     [not found] ` <handler.39178.D39178.15804639026571.notifdone@debbugs.gnu.org>
2020-01-31 15:26   ` bug#39178: closed (Re: bug#39178: 27.0.50; [PATCH] Fix: gdb-mi cannot recover from handler function error) Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pnf0klj3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39178-done@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.