From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 5557@debbugs.gnu.org, larsi@gnus.org, lennart.borgman@gmail.com
Subject: bug#5557: <left-margin> <double-wheel-down> is undefined
Date: Thu, 13 Aug 2020 16:06:34 +0300 [thread overview]
Message-ID: <83pn7un19h.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmrmej6O9GFhiuRekxzUCW5wTs+8SUdZtVDkPcRTPA6+g@mail.gmail.com> (message from Stefan Kangas on Wed, 12 Aug 2020 22:34:10 -0700)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 12 Aug 2020 22:34:10 -0700
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>, 5557@debbugs.gnu.org,
> lennart.borgman@gmail.com
>
> > Nowadays practically all applications scroll the window vertically
> > regardless of where the mouse pointer is - even when it's on the
> > horizontal scroll bar. The only exception is the title bar where some
> > window managers optionally "roll" the window in or out.
>
> That strengthens the case for doing the same in Emacs.
>
> I have attached a patch which implements this functionality.
> Any comments?
I have some:
> +(defun mouse-wheel--create-scroll-keys-get-key (binding event)
> + "Given BINDING and EVENT, return symbol for key.
> +Arguments are like in `mouse-wheel--create-scroll-keys'."
> + (intern (concat (pcase (caar binding)
> + ('alt "A-") ('control "C-") ('hyper "H-")
> + ('meta "M-") ('shift "S-") ('super "s-"))
> + (symbol-name event))))
I don't think I understand why we want to usurp mouse-wheel with every
possible modifier. I think the request was to honor only unmodified
mouse-wheel scrolls, no? Let's leave the modifiers to user bindings.
> +(defun mouse-wheel--create-scroll-keys (binding event)
> + "Return list of key vectors for BINDING and EVENT.
> +BINDING is an element in `mouse-wheel-scroll-amount'. EVENT is
> +an event used for scrolling, e.g. `mouse-wheel-down-event'."
> + (let ((prefixes (list 'left-margin 'right-margin
> + 'left-fringe 'right-fringe))
Martin says (and I concur) that we should also do this on horizontal
scroll bars and on the mode/header-lines.
Finally, this needs a NEWS entry.
Thanks.
next prev parent reply other threads:[~2020-08-13 13:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 13:01 bug#5557: <left-margin> <double-wheel-down> is undefined Lennart Borgman
2019-10-01 15:36 ` Lars Ingebrigtsen
2019-10-01 16:09 ` Eli Zaretskii
2019-10-01 16:19 ` Lars Ingebrigtsen
2019-10-01 16:26 ` Eli Zaretskii
2019-10-01 16:32 ` Lars Ingebrigtsen
2019-10-01 16:36 ` Eli Zaretskii
2019-10-01 17:39 ` Stefan Kangas
2019-10-01 18:31 ` Eli Zaretskii
2019-10-01 18:43 ` Stefan Kangas
2019-10-01 19:06 ` Eli Zaretskii
2019-10-02 8:55 ` martin rudalics
2019-10-03 15:35 ` Lars Ingebrigtsen
2019-10-03 18:11 ` martin rudalics
2020-08-13 5:34 ` Stefan Kangas
2020-08-13 8:42 ` Lars Ingebrigtsen
2020-08-13 13:06 ` Eli Zaretskii [this message]
2020-08-14 18:38 ` Stefan Kangas
2020-08-14 19:13 ` Eli Zaretskii
2020-08-14 21:34 ` Stefan Kangas
2020-08-15 17:40 ` Eli Zaretskii
2020-08-16 13:41 ` Stefan Kangas
2020-08-16 14:48 ` Eli Zaretskii
2020-08-16 15:57 ` Stefan Kangas
2020-08-17 13:30 ` Stefan Kangas
2020-08-22 7:32 ` Eli Zaretskii
2020-08-22 11:48 ` Stefan Kangas
2020-08-22 11:59 ` Eli Zaretskii
2020-08-22 12:11 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pn7un19h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=5557@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=lennart.borgman@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.