From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line. Date: Tue, 17 Nov 2020 18:55:26 +0200 Message-ID: <83pn4brkht.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18658"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44702@debbugs.gnu.org, tom@tromey.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 17 18:14:00 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kf4YK-0004if-Ac for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Nov 2020 18:14:00 +0100 Original-Received: from localhost ([::1]:36140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf4YJ-0000Hx-9v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Nov 2020 12:13:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf4Gw-0007Ou-QB for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 11:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf4Gw-000894-BJ for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 11:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kf4Gw-0006UJ-Aj for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2020 11:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2020 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44702-submit@debbugs.gnu.org id=B44702.160563213924904 (code B ref 44702); Tue, 17 Nov 2020 16:56:02 +0000 Original-Received: (at 44702) by debbugs.gnu.org; 17 Nov 2020 16:55:39 +0000 Original-Received: from localhost ([127.0.0.1]:32775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf4GZ-0006Tb-Bf for submit@debbugs.gnu.org; Tue, 17 Nov 2020 11:55:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf4GW-0006TM-J2 for 44702@debbugs.gnu.org; Tue, 17 Nov 2020 11:55:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57443) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf4GQ-0007vf-Rq; Tue, 17 Nov 2020 11:55:30 -0500 Original-Received: from [176.228.60.248] (port=1598 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kf4GQ-00036P-8m; Tue, 17 Nov 2020 11:55:30 -0500 In-Reply-To: (message from Stefan Kangas on Tue, 17 Nov 2020 04:30:45 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193558 Archived-At: > From: Stefan Kangas > Date: Tue, 17 Nov 2020 04:30:45 -0800 > Cc: tom@tromey.com > > I think the "Author" header line in package.el does not accurately > reflect the contributions to that file. In particular, I think Tom > Tromey should be listed as the sole author of package.el, in line with > our practices and to recognize his contribution. > > Please see the attached patch and compare it the output of the following > command: > > $ git shortlog -sn -- lisp/emacs-lisp/package.el | cat -n > > 1 132 Artur Malabarba > 2 54 Glenn Morris > 3 52 Stefan Monnier > 4 46 Chong Yidong > 5 40 Paul Eggert > 6 23 Stefan Kangas > 7 16 Dmitry Gutov > 8 11 Lars Ingebrigtsen > 9 8 Daiki Ueno > 10 8 Juanma Barranquero > 11 7 Eli Zaretskii > 12 7 Sam Steingold > 13 5 Noam Postavsky > 14 5 Ted Zlatanov > 15 4 John Wiegley > 16 4 Pieter van Oostrum > 17 3 Basil L. Contovounesios > 18 3 Bastien Guerry > 19 3 Nicolas Richard > 20 3 Phil Hagelberg > 21 3 Thien-Thi Nguyen > 22 3 Thierry Volpiatto > 23 3 Thomas Fitzsimmons > 24 2 Chunyang Xu > 25 2 Daniel Hackney > > Any objections? The number of commits doesn't necessarily tell how significant was the contribution; you need to count the number of added/changed lines instead. As an extreme example, the original author who write a package from scratch and installed it in a single commit will be at the tail of your list, but that doesn't express correctly the contribution of that person.