all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 44702@debbugs.gnu.org, tom@tromey.com
Subject: bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.
Date: Tue, 17 Nov 2020 18:55:26 +0200	[thread overview]
Message-ID: <83pn4brkht.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmsTw-GemmMqfGrzaJ7Y1UQkNCcnd2unvRPbFVT-BfuRw@mail.gmail.com> (message from Stefan Kangas on Tue, 17 Nov 2020 04:30:45 -0800)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 17 Nov 2020 04:30:45 -0800
> Cc: tom@tromey.com
> 
> I think the "Author" header line in package.el does not accurately
> reflect the contributions to that file.  In particular, I think Tom
> Tromey should be listed as the sole author of package.el, in line with
> our practices and to recognize his contribution.
> 
> Please see the attached patch and compare it the output of the following
> command:
> 
> $ git shortlog -sn -- lisp/emacs-lisp/package.el | cat -n
> 
>      1	   132	Artur Malabarba
>      2	    54	Glenn Morris
>      3	    52	Stefan Monnier
>      4	    46	Chong Yidong
>      5	    40	Paul Eggert
>      6	    23	Stefan Kangas
>      7	    16	Dmitry Gutov
>      8	    11	Lars Ingebrigtsen
>      9	     8	Daiki Ueno
>     10	     8	Juanma Barranquero
>     11	     7	Eli Zaretskii
>     12	     7	Sam Steingold
>     13	     5	Noam Postavsky
>     14	     5	Ted Zlatanov
>     15	     4	John Wiegley
>     16	     4	Pieter van Oostrum
>     17	     3	Basil L. Contovounesios
>     18	     3	Bastien Guerry
>     19	     3	Nicolas Richard
>     20	     3	Phil Hagelberg
>     21	     3	Thien-Thi Nguyen
>     22	     3	Thierry Volpiatto
>     23	     3	Thomas Fitzsimmons
>     24	     2	Chunyang Xu
>     25	     2	Daniel Hackney
> 
> Any objections?

The number of commits doesn't necessarily tell how significant was the
contribution; you need to count the number of added/changed lines
instead.  As an extreme example, the original author who write a
package from scratch and installed it in a single commit will be at
the tail of your list, but that doesn't express correctly the
contribution of that person.





      parent reply	other threads:[~2020-11-17 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 12:30 bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line Stefan Kangas
2020-11-17 16:29 ` Glenn Morris
2020-11-17 16:55   ` Stefan Kangas
2020-11-17 16:55 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pn4brkht.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=44702@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.