From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15069: [PATCH] Bug: 15069: Correct functioning in the *scratch* buffer Date: Sat, 22 May 2021 09:34:19 +0300 Message-ID: <83pmxjl1jo.fsf@gnu.org> References: <52077652.1050901@fastmail.co.uk> <87bl93anba.fsf@host.localdomain> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: poenikatu@fastmail.co.uk, stefan@marxist.se, 15069@debbugs.gnu.org To: pillule Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 22 08:35:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkLEK-0009J2-Fy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 May 2021 08:35:24 +0200 Original-Received: from localhost ([::1]:46928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkLEJ-0006Id-3P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 May 2021 02:35:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkLDy-0006IE-Me for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 02:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkLDy-0001u6-Ea for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 02:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkLDy-0002iK-Aq for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 02:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 May 2021 06:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 15069-submit@debbugs.gnu.org id=B15069.162166526910380 (code B ref 15069); Sat, 22 May 2021 06:35:02 +0000 Original-Received: (at 15069) by debbugs.gnu.org; 22 May 2021 06:34:29 +0000 Original-Received: from localhost ([127.0.0.1]:38207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkLDQ-0002hM-Qb for submit@debbugs.gnu.org; Sat, 22 May 2021 02:34:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkLDO-0002h8-Ob for 15069@debbugs.gnu.org; Sat, 22 May 2021 02:34:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52302) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkLDI-0001Tm-Kh; Sat, 22 May 2021 02:34:20 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4425 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkLDI-0001jg-2p; Sat, 22 May 2021 02:34:20 -0400 In-Reply-To: <87bl93anba.fsf@host.localdomain> (message from pillule on Fri, 21 May 2021 19:39:37 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207010 Archived-At: > From: pillule > Date: Fri, 21 May 2021 19:39:37 +0000 > Cc: Sian Mountbatten , > Stefan Kangas > > It has been pointed the instructions for `count-words-in-defun` are > ambiguous : One can expect to evaluate the sexp in the Info manual but > that would not work, so this commit explicit that it must be done in a > clean buffer (= with a valid syntaxe tree). > > Copyright-paperwork-exempt: yes > --- > doc/lispintro/emacs-lisp-intro.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/doc/lispintro/emacs-lisp-intro.texi b/doc/lispintro/emacs-lisp-intro.texi > index fade4096e3..ba5fae4ff0 100644 > --- a/doc/lispintro/emacs-lisp-intro.texi > +++ b/doc/lispintro/emacs-lisp-intro.texi > @@ -14650,7 +14650,8 @@ Let's re-use @kbd{C-c =} as a convenient keybinding: > > Now we can try out @code{count-words-defun}: install both > @code{count-words-in-defun} and @code{count-words-defun}, and set the > -keybinding, and then place the cursor within the following definition: > +keybinding, and then place the cursor within the following definition, > +in a clean scratch buffer: It says "install the functions", which means they should be evaluated or loaded, and that tells you the Lisp code should already be available in some Lisp buffer, whether it's *scratch* or some *.el file. So why did you think it speaks about the text in the Info buffer? That's not the intent of the text, and the text says as much. So I'm not sure we should install this fix. Any other opinions? In any case: . just talking about *scratch* is too restrictive . the commit log message is not according to our conventions (see CONTRIBUTE) Thanks.