From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: 48578@debbugs.gnu.org
Subject: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time
Date: Wed, 26 May 2021 16:43:20 +0300 [thread overview]
Message-ID: <83pmxda9vr.fsf@gnu.org> (raw)
In-Reply-To: <xjfr1hvkkww.fsf@sdf.org> (message from Andrea Corallo on Tue, 25 May 2021 13:22:39 +0000)
> From: Andrea Corallo <akrl@sdf.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, 48578@debbugs.gnu.org
> Date: Tue, 25 May 2021 13:22:39 +0000
>
> diff --git a/src/comp.c b/src/comp.c
> index 340ed85038..8e40ea0f25 100644
> --- a/src/comp.c
> +++ b/src/comp.c
> @@ -4008,15 +4008,15 @@ DEFUN ("comp-el-to-eln-rel-filename", Fcomp_el_to_eln_rel_filename,
> {
> CHECK_STRING (filename);
>
> - /* Use `file-truename' or fall back to `expand-file-name' when the
> - first is not available (bug#44701).
> -
> - `file-truename' is not available only for a short phases of the
> - bootstrap before file.el is loaded, given we do not symlink
> - inside the build directory this should work. */
> - filename = NILP (Ffboundp (intern_c_string ("file-truename")))
> - ? Fexpand_file_name (filename, Qnil)
> - : CALL1I (file-truename, filename);
> + /* `file-truename' is not available only during bootstrap before
> + file.el is loaded. */
> +#ifndef WINDOWSNT
> + char *file_normalized = realpath (SSDATA (filename), NULL);
> +#else
> + char *file_normalized = ??? ;
> +#endif
> + filename = Fexpand_file_name (build_string (file_normalized), Qnil);
> + xfree (file_normalized);
>
> if (NILP (Ffile_exists_p (filename)))
> xsignal1 (Qfile_missing, filename);
Thanks, this works. But I have a few questions/comments:
. why do you use Fexpand_file_name _after_ realpath? shouldn't we
call it before realpath instead?
. we need to encode the file name before passing it to realpath, and
decode the result, right?
. realpath could potentially return NULL, and we should check for
that, and return the result of Fexpand_file_name if it does
. we don't need to support remote files here via file-handlers,
right?
If you agree with the above, I will prepare a proper patch and install
it, including the necessary changes for WINDOWSNT.
next prev parent reply other threads:[~2021-05-26 13:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 7:20 bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time Eli Zaretskii
2021-05-24 6:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-24 7:30 ` Eli Zaretskii
2021-05-24 7:47 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-24 8:10 ` Eli Zaretskii
2021-05-24 8:48 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-24 16:22 ` Eli Zaretskii
2021-05-25 12:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 13:02 ` Eli Zaretskii
2021-05-25 13:18 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 13:22 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-26 13:43 ` Eli Zaretskii [this message]
2021-05-27 11:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-27 13:45 ` Eli Zaretskii
2021-05-29 7:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-29 8:57 ` Eli Zaretskii
2021-05-25 18:13 ` Basil L. Contovounesios
2021-05-25 18:15 ` Eli Zaretskii
2021-05-25 18:31 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmxda9vr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48578@debbugs.gnu.org \
--cc=akrl@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.