all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org
Subject: bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer
Date: Thu, 25 Nov 2021 13:21:02 +0200	[thread overview]
Message-ID: <83pmqo5vmp.fsf@gnu.org> (raw)
In-Reply-To: <612d659daabc268505c4@heytings.org> (message from Gregory Heytings on Thu, 25 Nov 2021 11:07:44 +0000)

> Date: Thu, 25 Nov 2021 11:07:44 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org
> 
> > Thanks, but I'd prefer a less obscure way of telling whether this is 
> > going into *Help* buffers.  Is this really the only way?
> 
> I agree with you that it's a bit obscure, and I tried to find a better 
> way, but couldn't.  Someone else might have a better idea.  I think 
> another possible way would be to query this-command:
> 
> (in-help (or (eq major-mode 'help-mode)
>               (and this-command
>                    (where-is-internal this-command help-map t))))
> 
> But somehow I find this even less elegant, and I'm less certain about its 
> correctness.

It's definitely not more elegant, agreed.

I do hope a better idea emerges.  Anybody?

> > Or maybe the mouse-face etc. should not be put as part of 
> > substitute-command-keys, but by the Help mode itself, when the text is 
> > already in the *Help* buffer?  As we use substitute-command-keys more 
> > and more, these problems will probably pop up more and more, so maybe we 
> > should rethink whether this part is really something it should do.
> >
> 
> With this patch it shouldn't happen outside of Help mode anymore.

Yes, but that's somewhat blunt a weapon, I think.  My idea was to
maybe let the caller decide whether this is wanted or not, if we are
going to use substitute-command-keys in way more contexts than it was
originally meant to.





  reply	other threads:[~2021-11-25 11:21 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87czmr5gr7.fsf.ref@yahoo.com>
2021-11-23 10:05 ` bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24  6:17   ` Phil Sainty
2021-11-24  7:53   ` Lars Ingebrigtsen
2021-11-24  9:28     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 10:58       ` Lars Ingebrigtsen
2021-11-24 11:15         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 11:27           ` Lars Ingebrigtsen
2021-11-24 11:36             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 16:39               ` Lars Ingebrigtsen
2021-11-24 17:05                 ` Andreas Schwab
2021-11-25  0:45                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-25 13:34                   ` Lars Ingebrigtsen
2021-11-26  0:38                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-26 12:36                       ` Lars Ingebrigtsen
2021-11-26 12:52                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-25 10:23   ` Gregory Heytings
2021-11-25 10:59     ` Eli Zaretskii
2021-11-25 11:07       ` Gregory Heytings
2021-11-25 11:21         ` Eli Zaretskii [this message]
2021-11-25 12:47           ` Robert Pluim
2021-11-25 13:20             ` Eli Zaretskii
2021-11-25 13:36               ` Lars Ingebrigtsen
2021-11-25 13:41           ` Gregory Heytings
2021-11-25 14:16             ` Eli Zaretskii
2021-11-25 14:55               ` Gregory Heytings
2021-11-25 15:15                 ` Eli Zaretskii
2021-11-25 22:45                   ` Gregory Heytings
2021-11-26  6:26                     ` Eli Zaretskii
2021-11-26  9:24                       ` Robert Pluim
2021-11-26 11:13                         ` Eli Zaretskii
2021-11-26 11:17                           ` Robert Pluim
2021-11-27 16:06                       ` Gregory Heytings
2021-11-27 16:08                         ` Gregory Heytings
2021-11-29 13:56                           ` Lars Ingebrigtsen
2021-11-29 14:05                             ` Eli Zaretskii
2021-11-29 14:13                               ` Lars Ingebrigtsen
2021-11-29 17:59                           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pmqo5vmp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52053@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.