bug#53740: 29.0.50; Buffers->Frames menu lists F1

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[chad brown]

[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]

When emacs is started in server mode, the Frames submenu of the Buffers
menu includes an entry F1, for the initial pseudo-frame. Selecting this
entry does nothing, but its presence is confusing.

  emacs -Q --daemon
  emacsclient -c
  <click on "Buffers", then "Frames" in the menu-bar>

In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.24,
cairo version 1.16.0)
 of 2022-02-01 built on penguin
Repository revision: 02054d9cd1f5c6a5ca3555207235522532477e10
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-native-compilation --with-gnutls --without-xwidgets
 --without-pop'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LC_COLLATE: C
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: en_US.UTF-8
  value of $LC_NUMERIC: en_US.UTF-8
  value of $LC_TIME: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media rmc puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp
comp-cstr warnings rx cl-seq cl-macs cl-extra help-mode seq gv subr-x
byte-opt cl-loaddefs cl-lib bytecomp byte-compile cconv server
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget keymap hashtable-print-readable backquote threads
dbusbind inotify dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 87470 5748)
 (symbols 48 7239 1)
 (strings 32 24622 2255)
 (string-bytes 1 832865)
 (vectors 16 18769)
 (vector-slots 8 287882 15791)
 (floats 8 42 27)
 (intervals 56 233 0)
 (buffers 992 13))

[-- Attachment #2: Type: text/html, Size: 4215 bytes --]

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

chad brown <chadpbrown@gmail.com> writes:

> When emacs is started in server mode, the Frames submenu of the Buffers
> menu includes an entry F1, for the initial pseudo-frame. Selecting this
> entry does nothing, but its presence is confusing. 

Should be fixed now on master, please test.

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Eli Zaretskii]

> Cc: 53740@debbugs.gnu.org
> Date: Thu, 03 Feb 2022 09:30:20 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> chad brown <chadpbrown@gmail.com> writes:
> 
> > When emacs is started in server mode, the Frames submenu of the Buffers
> > menu includes an entry F1, for the initial pseudo-frame. Selecting this
> > entry does nothing, but its presence is confusing. 
> 
> Should be fixed now on master, please test.

It doesn't seem to be fixed for me, neither on MS-Windows with a GUI
frame created by emacsclient, nor on GNU/Linux with TTY frames.  In
both cases, after emacsclient creates a client frame, the
Buffers->Frames menu shows the F1 frame that cannot be switched to.

What do you see on your system that caused you think the bug is fixed?
What recipe did you try?

Your change uses frame-initial-frame, but that is usually nil, so I'm
not sure this is the correct implementation.

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

> What do you see on your system that caused you think the bug is fixed?
> What recipe did you try?

I started a client by running Emacs as a daemon, then ran:

  emacsclient -c

And didn't see any frame submenu under the Buffers menu inside the newly
created frame.

> Your change uses frame-initial-frame, but that is usually nil, so I'm
> not sure this is the correct implementation.

Hmm, I'm not sure what the problem might be then.

Thanks.

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: chadpbrown@gmail.com,  53740@debbugs.gnu.org
> Date: Thu, 03 Feb 2022 17:56:35 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > What do you see on your system that caused you think the bug is fixed?
> > What recipe did you try?
> 
> I started a client by running Emacs as a daemon, then ran:

Did you start the daemon with -Q?

>   emacsclient -c
> 
> And didn't see any frame submenu under the Buffers menu inside the newly
> created frame.

Well, I do see the frame submenu, and the initial frame F1 there.

Can you try this in Emacs started by SSH login into a remote host?

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Robert Pluim]

>>>>> On Thu, 03 Feb 2022 12:30:40 +0200, Eli Zaretskii <eliz@gnu.org> said:

    Eli> Well, I do see the frame submenu, and the initial frame F1 there.

    Eli> Can you try this in Emacs started by SSH login into a remote host?

The F1 frame shows up in the frame submenu when doing emacsclient -c
to an emacs running in daemon mode in an ssh session, with both tty
and graphical frame creation, on GNU/Linux.

(and frame-initial-frame is nil).

Robert
-- 

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Po Lu <luangruo@yahoo.com>,  53740@debbugs.gnu.org,  chadpbrown@gmail.com
> Date: Thu, 03 Feb 2022 11:54:55 +0100
> 
> >>>>> On Thu, 03 Feb 2022 12:30:40 +0200, Eli Zaretskii <eliz@gnu.org> said:
> 
>     Eli> Well, I do see the frame submenu, and the initial frame F1 there.
> 
>     Eli> Can you try this in Emacs started by SSH login into a remote host?
> 
> The F1 frame shows up in the frame submenu when doing emacsclient -c
> to an emacs running in daemon mode in an ssh session, with both tty
> and graphical frame creation, on GNU/Linux.
> 
> (and frame-initial-frame is nil).

Thanks, I hope I fixed this now on the master branch.

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Robert Pluim]

>>>>> On Thu, 03 Feb 2022 13:06:48 +0200, Eli Zaretskii <eliz@gnu.org> said:

    Eli> Thanks, I hope I fixed this now on the master branch.

Yes, or should I say: 👍 (How do you do, fellow kids?)

Would it be useful to have the TTY frames named something other than
Fn?

Robert
-- 

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: luangruo@yahoo.com,  53740@debbugs.gnu.org,  chadpbrown@gmail.com
> Date: Thu, 03 Feb 2022 12:33:57 +0100
> 
> Would it be useful to have the TTY frames named something other than
> Fn?

By default?  (Because we already have "M-x set-frame-name".)  What
would you call them?

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Robert Pluim]

>>>>> On Thu, 03 Feb 2022 13:52:27 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: luangruo@yahoo.com,  53740@debbugs.gnu.org,  chadpbrown@gmail.com
    >> Date: Thu, 03 Feb 2022 12:33:57 +0100
    >> 
    >> Would it be useful to have the TTY frames named something other than
    >> Fn?

    Eli> By default?  (Because we already have "M-x set-frame-name".)  What
    Eli> would you call them?

"Fn <tty>" or similar?

Robert
-- 

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: luangruo@yahoo.com,  53740@debbugs.gnu.org,  chadpbrown@gmail.com
> Date: Thu, 03 Feb 2022 14:30:54 +0100
> 
> >>>>> On Thu, 03 Feb 2022 13:52:27 +0200, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> From: Robert Pluim <rpluim@gmail.com>
>     >> Cc: luangruo@yahoo.com,  53740@debbugs.gnu.org,  chadpbrown@gmail.com
>     >> Date: Thu, 03 Feb 2022 12:33:57 +0100
>     >> 
>     >> Would it be useful to have the TTY frames named something other than
>     >> Fn?
> 
>     Eli> By default?  (Because we already have "M-x set-frame-name".)  What
>     Eli> would you call them?
> 
> "Fn <tty>" or similar?

Is that really so different?  It will take more space on the mode
line, for starters.

bug#53740: 29.0.50; Buffers->Frames menu lists F1

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

> Did you start the daemon with -Q?

No, but I see the problem now with -Q.
I'll try to fix this again later.  Thanks.