From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sun, 13 Feb 2022 08:24:53 +0200 Message-ID: <83pmnrqo5m.fsf@gnu.org> References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> <83tud3ri2n.fsf@gnu.org> <83r187rhd8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 13 07:26:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ8Ky-0004BB-QO for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 07:26:20 +0100 Original-Received: from localhost ([::1]:39180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJ8Kx-00081W-DD for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 01:26:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJ8Jf-0007Kl-SR for emacs-devel@gnu.org; Sun, 13 Feb 2022 01:24:59 -0500 Original-Received: from [2001:470:142:3::e] (port=59500 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJ8Je-0008GI-QE; Sun, 13 Feb 2022 01:24:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+AtAoxfpGL2euKPTVSSKd5gPDenr9mMCDdceIscQV/w=; b=k8o7r3plottg ZVsD0IA5ZRJOl8bRl9yRSn+oOfRhQkIGMPQFjFcHHabZJm9nuP+SZzq1W4ZfIy8t/GYKBW/MF3gXD lvNahl223fagdJcuJBAeuFFqyW/CNy3mct+gFMdh/uZ3kZqQz5YZwpq+0O9TKjoA9ajNCUbz/w1DI 7CJZIWaqRegRYPe1VUqi8TvkJpQoIlwFsXfKTgXl9ym5PgK7o5H0YGUYwes1fpkU7yY0RudSHgN6C B8KSwEGtpwatizCAbgOF76wOCPGMQPV8SM2U7KQkojojjAUBWiLW+mqz7MWIoLB7RU5jQIXy0iobr 1GyHHYjO1p4Llw5CZ/Tb0Q==; Original-Received: from [87.69.77.57] (port=2107 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJ8Je-0005Y3-7X; Sun, 13 Feb 2022 01:24:58 -0500 In-Reply-To: (message from Stefan Monnier on Sat, 12 Feb 2022 15:32:16 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286202 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org, larsi@gnus.org > Date: Sat, 12 Feb 2022 15:32:16 -0500 > > >> > (format (if (and (>= (mod file-size 1.0) 0.05) > >> > (< (mod file-size 1.0) 0.95)) > >> > "%.1f%s%s" > >> > "%.0f%s%s") > >> > >> Why is it a feature > > > > It's a feature by definition: there's code that intentionally does > > that. > > > >> to waste those two perfect good characters on such irrelevant > >> details? > > > > A feature doesn't have to be liked to be a feature. > > No, but if we don't like it we can remove it. > Do you find this feature useful? If so, can you give me an idea what > you like about it? AFAIU, it attempts to show more significant digits when the value is near a round power.