From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Warning in svg_load_image
Date: Mon, 21 Feb 2022 15:51:15 +0200 [thread overview]
Message-ID: <83pmnguy3w.fsf@gnu.org> (raw)
In-Reply-To: <87y224e3x3.fsf@yahoo.com> (message from Po Lu on Mon, 21 Feb 2022 21:37:44 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 21 Feb 2022 21:37:44 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Not really, but does the below fix these, by chance?
>
> Unfortunately not. Now I get this slightly different warning:
What about the one below:
diff --git a/src/image.c b/src/image.c
index e2ba744..fca5236 100644
--- a/src/image.c
+++ b/src/image.c
@@ -10632,9 +10632,9 @@ svg_load_image (struct frame *f, struct image *img, char *contents,
strncpy (css, SSDATA (lcss), SBYTES (lcss));
*(css + SBYTES (lcss) + 1) = 0;
}
-#endif
+#endif /* LIBRSVG >= 2.48.0 */
-#else
+#else /* LIBRSVG < 2.32.0 */
/* Make a handle to a new rsvg object. */
rsvg_handle = rsvg_handle_new ();
eassume (rsvg_handle);
@@ -10657,7 +10657,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents,
it for further writes. */
rsvg_handle_close (rsvg_handle, &err);
if (err) goto rsvg_error;
-#endif
+#endif /* LIBRSVG 2.32.0 */
/* Get the image dimensions. */
#if LIBRSVG_CHECK_VERSION (2, 46, 0)
@@ -10727,13 +10727,13 @@ svg_load_image (struct frame *f, struct image *img, char *contents,
viewbox_height = viewbox.y + viewbox.height;
}
}
-#else
+#else /* LIBRSVG < 2.46.0 */
/* In librsvg before 2.46.0, guess the viewbox from the image dimensions. */
RsvgDimensionData dimension_data;
rsvg_handle_get_dimensions (rsvg_handle, &dimension_data);
viewbox_width = dimension_data.width;
viewbox_height = dimension_data.height;
-#endif
+#endif /* LIBRSVG < 2.46.0 */
#ifdef HAVE_NATIVE_TRANSFORMS
compute_image_size (viewbox_width, viewbox_height, img,
@@ -10777,7 +10777,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents,
"xmlns:xi=\"http://www.w3.org/2001/XInclude\" "
"style=\"color: #%06X; fill: currentColor;\" "
"width=\"%d\" height=\"%d\" preserveAspectRatio=\"none\" "
- "viewBox=\"0 0 %f %f\">"
+ "viewBox=\"0 0 %5.0f %5.0f\">"
"<rect width=\"100%%\" height=\"100%%\" fill=\"#%06X\"/>"
"<xi:include href=\"data:image/svg+xml;base64,%s\"></xi:include>"
"</svg>";
@@ -10801,7 +10801,9 @@ svg_load_image (struct frame *f, struct image *img, char *contents,
if (buffer_size <= snprintf (wrapped_contents, buffer_size, wrapper,
foreground & 0xFFFFFF, width, height,
- viewbox_width, viewbox_height,
+ /* Sanitize the viewBox dimensions. */
+ min (viewbox_width, 10000.),
+ min (viewbox_height, 10000.),
background & 0xFFFFFF,
SSDATA (encoded_contents)))
goto rsvg_error;
next prev parent reply other threads:[~2022-02-21 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ilt8hcz4.fsf.ref@yahoo.com>
2022-02-21 7:53 ` Warning in svg_load_image Po Lu
2022-02-21 13:26 ` Eli Zaretskii
2022-02-21 13:37 ` Po Lu
2022-02-21 13:51 ` Eli Zaretskii [this message]
2022-02-22 3:53 ` Po Lu
2022-02-22 12:32 ` Eli Zaretskii
2022-02-22 12:45 ` Andreas Schwab
2022-02-22 13:02 ` Po Lu
2022-02-23 17:11 ` Michael Welsh Duggan
2022-02-23 17:37 ` Eli Zaretskii
2022-02-23 21:58 ` Michael Welsh Duggan
2022-02-24 6:47 ` Eli Zaretskii
2022-02-23 22:55 ` Andreas Schwab
2022-02-24 6:53 ` Eli Zaretskii
[not found] ` <87pmndmrsz.fsf@md5i.com>
2022-02-24 0:50 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmnguy3w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.