From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 29.0.50 master freeze on macOS Date: Tue, 19 Jul 2022 19:02:46 +0300 Message-ID: <83pmi1m6op.fsf@gnu.org> References: <8c1839f7ace24a57dbce351ef546c437@condition-alpha.com> <838rovu685.fsf@gnu.org> <83a69as15c.fsf@gnu.org> <5cd7689bb258db5a267a908c9cb18e0c@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 19 18:06:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDpkM-0006wq-F4 for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Jul 2022 18:06:54 +0200 Original-Received: from localhost ([::1]:59976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDpkL-00031k-9x for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Jul 2022 12:06:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDpgc-0006Xl-TB for emacs-devel@gnu.org; Tue, 19 Jul 2022 12:03:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDpgX-0001XY-Kq; Tue, 19 Jul 2022 12:03:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5BqM7EdURh2wjDML9n0D95GK6HRDS0BdaJb7DG1G44Q=; b=k03CxHEhyMKzDSLveQD7 CsVOJgJH9RuDscUYdlUc7jjb8zHAKlfpkO/AYUzMfc4kkObxq4D02p0/TY/QzRVWIR6VbtGZzfWFw oSVuODVORSIEJuuQiAhItrRgvu+CKp70Ory+cuVKOqf9WdhcZvm+OyYKCl8AABbVgZM/VS+IG1HX2 XGzo6+J/CieD8fDLW+DaDmsFng+BqMrx/DfOFV/y6p2RIFLyq4A/MoXB7tqXU1L/xJfGQIG5hA+3d ONGZdICsDO2597WRd//Pen2tAQMclqO3QNPSrjFxlilfvFpndazVJmZDMu7gj7z/ji0oscUdmR9wy UCcpAmVC8Dc7rA==; Original-Received: from [87.69.77.57] (port=4970 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDpgW-00076F-UJ; Tue, 19 Jul 2022 12:02:57 -0400 In-Reply-To: <5cd7689bb258db5a267a908c9cb18e0c@condition-alpha.com> (message from Alexander Adolf on Tue, 19 Jul 2022 17:27:14 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292279 Archived-At: > From: Alexander Adolf > Cc: emacs-devel@gnu.org > Date: Tue, 19 Jul 2022 17:27:14 +0200 > > It loops in face_inherited_attr(). Here is the call stack: > [...] > In face_inherited_attr(), variable values were: > > w window * NULL > f frame * NULL > attrs Lisp_Object * NULL > attr_idx lface_attribute_index LFACE_EXTEND_INDEX > named_merge_points named_merge_point * 0x7ffeee3e9018 0x00007ffeee3e9018 > inherited_attrs Lisp_Object [20] > attr_val Lisp_Object 0xf3f0 0x000000000000f3f0 > > Inside the while() loop, the if (CONSP (parent_face)) fails, and it > executes the else branch. From there, it calls > > get_lface_attributes (struct window *w, > struct frame *f, Lisp_Object face_name, > Lisp_Object attrs[LFACE_VECTOR_SIZE], bool signal_p, > struct named_merge_point *named_merge_points) > > which executes the “default case, no remapping” path. > > Interestingly, the window and frame pointers are NULL in the context of > face_inherited_attr() only. I.e. in both the function that calls it > (merge_named_face()), and in the function called by it > (get_lface_attributes()), the pointers have the same, non-NULL value. > > Hope this helps? If you want me to look into more specific things next > time it happens, please don't hesitate to drop me a note. This helps, thanks. But since the loop is in that place, it is very important to see the definition of the face which causes this. Specifically: . what is the value of face_name argument to merge_named_face that calls face_inherited_attr? it should be a symbol. . what are the attributes in the attrs[] argument to face_inherited_attr? this is a vector of Lisp objects, and the meaning of each component can be seen in the lface_attribute_index enumeration Thanks.