From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57129: 29.0.50; Improve behavior of conditionals in Eshell Date: Mon, 15 Aug 2022 19:49:00 +0300 Message-ID: <83pmh1h2pv.fsf@gnu.org> References: <8fb3461d-b7eb-23c4-2736-cdd6dfeb1aa0@gmail.com> <87mtc9o5af.fsf@gnus.org> <83h72gmxtq.fsf@gnu.org> <7c04a92b-85f4-41c3-917b-4716cca2b9d6@gmail.com> <83pmh3l8ey.fsf@gnu.org> <9ca08054-5b73-a13e-0478-d838b650317b@gmail.com> <837d3bl1tx.fsf@gnu.org> <5ff283e8-9ced-5894-1075-43bba580185e@gmail.com> <831qthiu0s.fsf@gnu.org> <7259f313-c6ef-bce8-ddc4-e35ecc27d856@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 57129@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 18:59:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNdQa-00026W-1Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 18:59:00 +0200 Original-Received: from localhost ([::1]:34770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNdQZ-0006Eo-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 12:58:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNdHu-0007m5-LY for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 12:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNdHu-0001PJ-9w for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 12:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNdHu-0000pZ-2p for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 12:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57129 X-GNU-PR-Package: emacs Original-Received: via spool by 57129-submit@debbugs.gnu.org id=B57129.16605821663142 (code B ref 57129); Mon, 15 Aug 2022 16:50:02 +0000 Original-Received: (at 57129) by debbugs.gnu.org; 15 Aug 2022 16:49:26 +0000 Original-Received: from localhost ([127.0.0.1]:43952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNdHJ-0000oc-Qo for submit@debbugs.gnu.org; Mon, 15 Aug 2022 12:49:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNdHF-0000oM-HO for 57129@debbugs.gnu.org; Mon, 15 Aug 2022 12:49:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNdHA-0001H6-14; Mon, 15 Aug 2022 12:49:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=s8vBEmJuz4w4qYkEUqhyjEaMg2Iq2W9XO8ltl59fGYU=; b=oWrMpT9ndt08 HaDEo2TVTfTRVB9zI72/QcX1YdxCkg5eIEFEtI7r9Nzvtg3dX/GZJwyluomKr5Qab84QFbbJc2gyp SGDtjOW3+uOajWhY0U8/WaELhl5B3dYKxH2+BAJYE2/BJw56ZbZDHZ/uassqY+YI/yHzHztABou7I OqviPsSTVzd812VcTqqC8k+Bvgr3TKZevwOYHttYZNa0iszL1bSLqBIL4takZIY8CmW1CSamGVqMp axcOHcSwgIs9G+e3AGduagIQ2dR7YFpMg6h6NXOp5SJyR+A4xxyI2dI/Se+SRXdqrj72+Gy1Oqgbm Q3J8SgLB51eAKdGGCu38mQ==; Original-Received: from [87.69.77.57] (port=2747 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNdH9-0005lQ-DA; Mon, 15 Aug 2022 12:49:15 -0400 In-Reply-To: <7259f313-c6ef-bce8-ddc4-e35ecc27d856@gmail.com> (message from Jim Porter on Mon, 15 Aug 2022 09:14:04 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239818 Archived-At: > Cc: larsi@gnus.org, 57129@debbugs.gnu.org > From: Jim Porter > Date: Mon, 15 Aug 2022 09:14:04 -0700 > > > All the 4 commands do what you say they should do. > > Hm, and I can't reproduce this on the prebuilt Emacs 29 snapshot from > July 18, which is from just before I merged the changes to > 'make-process', so it's definitely possible that this is due to those > commits. > > Does reverting 4e59830bc0ab17cdbd85748b133c97837bed99e3 and > d7b89ea4077d4fe677ba0577245328819ee79cdc fix the issue? I checked > locally, and they should revert cleanly at least. > > It might also be interesting to revert just the changes from d7b89ea in > lisp/eshell/esh-proc.el. I don't think any of the changes I made to the > C sources should impact this, since a) I was careful to keep the logic > as close to before as I could, and b) it just changes the logic for > creating a PTY, which doesn't work on MS Windows anyway. None of these reverts fixes the issue. I tried both the tests in eshell-tests.el and the problematic command: *cat $ | *cat > I did notice one weird issue though, and maybe this has something to do > with the problem: on MS Windows, if I run any command with a > $, the second and subsequent times, it warns me about > changing the temp file, e.g.: > > 3Zz80A has changed since visited or saved. Save anyway? (yes or no) > > This probably shouldn't do that, and it could definitely cause issues in > the tests, which can't prompt the user for things like that. I guess this means you somehow reuse the same temporary file on MS-Windows? Maybe change the test a bit so that the file name definitely differs?