From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59290: 29.0.50; [PATCH] Buffer-localize temporary-goal-column Date: Wed, 16 Nov 2022 14:24:45 +0200 Message-ID: <83pmdngk8i.fsf@gnu.org> References: <87o7t76g39.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30530"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59290@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 16 13:30:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovHYk-0007gf-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Nov 2022 13:30:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovHUY-0002nb-3W; Wed, 16 Nov 2022 07:26:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovHUT-0002mM-V5 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 07:26:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovHUQ-0001nR-Lh for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 07:26:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovHUQ-0004rW-3i for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 07:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2022 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59290-submit@debbugs.gnu.org id=B59290.166860150518618 (code B ref 59290); Wed, 16 Nov 2022 12:26:02 +0000 Original-Received: (at 59290) by debbugs.gnu.org; 16 Nov 2022 12:25:05 +0000 Original-Received: from localhost ([127.0.0.1]:56280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovHTV-0004qE-9P for submit@debbugs.gnu.org; Wed, 16 Nov 2022 07:25:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovHTR-0004pd-Is for 59290@debbugs.gnu.org; Wed, 16 Nov 2022 07:25:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovHTG-0001MP-IL; Wed, 16 Nov 2022 07:24:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=dU5BR6/RalhykWeg2jTZmoIjzOba11aEn+tbLnAv7xc=; b=SkJI3si/dyBYAAQ8lLFZ dOLCozE44dAwUqEzItnNMM1Gp/oIA7aFnsHsfJFFqmeTbkVt64O2iAz1dcw2ph+SwvZrjJmTkegSd OMv6XR17PLgbOyKgCxibzI62RBm7NWA7tg2kNLS33SSlZsnts79rZ91AnGzZrqqh+wEo7qVZ8ZALM OixcSjic9O+Qch+1XDI3G2pNJOyOg9xP/TBh3wOtMHOgpC7eOAWA4eYsz9EBEyv/FATnAEarXvMFT YXeiMqNevJYqqyWEul7UaadOUam2hNCeLBiJOi0jCKhnVJ2ar5RLICzJkR4UkVe75P5OSBVv+7dqx Kn7x87+IrxA0KQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovHTD-00058d-QD; Wed, 16 Nov 2022 07:24:50 -0500 In-Reply-To: <87o7t76g39.fsf@dick> (message from dick on Tue, 15 Nov 2022 16:52:10 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248007 Archived-At: > From: dick > Date: Tue, 15 Nov 2022 16:52:10 -0500 > > emacs -Q -l cl-lib --eval " \ > (with-temp-buffer \ > (save-excursion \ > (insert \"עִבְרִית\nעִבְרִית\")) \ > (call-interactively (function next-line)) \ > (with-temp-buffer \ > (save-excursion (insert \"English\nEnglish\")) \ > (call-interactively (function next-line)) \ > (cl-assert (zerop (current-column)))))" > > > >From 44ca27270bdd7786ddb36469149128b6d18aac9a Mon Sep 17 00:00:00 2001 > From: dickmao > Date: Tue, 15 Nov 2022 16:03:48 -0500 > Subject: [PATCH] Temporary goal column leaks > > * lisp/simple.el (temporary-goal-column): Buffer-localize. > * test/lisp/simple-tests.el (line-move-visual-goal-column-leakage): > Test it. Thanks, but please provide a meaningful commit log message with an explanation of the problem and the solution. AFAIU, it isn't self-evident. For example, if I invoke the program interactively in a running Emacs session, the problem doesn't happen. Your test seems to acknowledge that, as is evidenced by this: > +(ert-deftest line-move-visual-goal-column-leakage () > + (skip-unless (not noninteractive)) <<<<<<<<<<<<<<<<<<<<<<< but without any explanation. With the root cause of this stated explicitly, it might be that we will want or at least consider a different solution.