From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59384: 29.0.50; Visiting files in Emacs Git pops up "unsafe variable" prompt Date: Sat, 19 Nov 2022 21:40:41 +0200 Message-ID: <83pmdi7mx2.fsf@gnu.org> References: <83h6yv85h4.fsf@gnu.org> <86wn7qaiep.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59384@debbugs.gnu.org To: Juri Linkov , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 19 20:41:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owTiD-000A1Z-Ud for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Nov 2022 20:41:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owTi4-0003l5-GC; Sat, 19 Nov 2022 14:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTi3-0003hb-31 for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owTi1-00023A-SN for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owTi1-00070C-Oc for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2022 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59384 X-GNU-PR-Package: emacs Original-Received: via spool by 59384-submit@debbugs.gnu.org id=B59384.166888684126881 (code B ref 59384); Sat, 19 Nov 2022 19:41:01 +0000 Original-Received: (at 59384) by debbugs.gnu.org; 19 Nov 2022 19:40:41 +0000 Original-Received: from localhost ([127.0.0.1]:41474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owThh-0006zV-BP for submit@debbugs.gnu.org; Sat, 19 Nov 2022 14:40:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owThg-0006zK-3u for 59384@debbugs.gnu.org; Sat, 19 Nov 2022 14:40:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTha-0001tF-By; Sat, 19 Nov 2022 14:40:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=faohNwWF2BWHrVVAiWZSdEMz1PXjYJP/MTszjcj/P4o=; b=qn2W+B0wam6H ttxd9DjHFsmNB3JJ/0e5fu2GXJtvZxFk5/vQ5HTYMuaLEi90g04S8NthoHs42MgR/2DWn+G7QYEBK RaDaaXFa/sy+874mu+MohKKrPxrWudVVEck9YHTU+LQQAJp5paFLt9UNYEhqIKnJXEP0raISvHZSc BTScQ9i26HUe4UwI7VdtpA99tIfEEqe5P9/G37E5D2KJgWvivG+UC3wOXdUYRRogf5FElV3XrFCJe dMR5f54beMKUdXY/N3Atiox4Inxkp2AaPLXEQhVGrs4cvbMsds7oN3tWmablHnWiQXVs2wzbm8k9v ObnogyUzHI+TUjbe2/QuKg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owThZ-0007BN-Os; Sat, 19 Nov 2022 14:40:34 -0500 In-Reply-To: <86wn7qaiep.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 19 Nov 2022 20:49:50 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248372 Archived-At: > From: Juri Linkov > Cc: 59384@debbugs.gnu.org > Date: Sat, 19 Nov 2022 20:49:50 +0200 > > > vc-git-annotate-switches : "-w" > > bug-reference-url-format : "https://debbugs.gnu.org/%s" > > diff-add-log-use-relative-names : t > > * vc-prepare-patches-separately : nil > > c-file-style : "GNU" > > c-noise-macro-names : ("INLINE" "NO_INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK") > > electric-quote-comment : nil > > electric-quote-string : nil > > indent-tabs-mode : t > > mode : bug-reference-prog > > > > The problem here AFAIU is that vc-prepare-patches-separately and its > > 'safep' property is not known to Emacs until vc.el is loaded. > > > > One way of fixing this would be to autoload the defcustom of this > > variable, but AFAIR this is sometimes frowned upon? > > Is there a standard solution already worked out for existing > variables like `vc-git-annotate-switches'? Maybe it is, but if so, I'm not aware of it. Stefan, any advice?