From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: yantar92@posteo.net, 60568@debbugs.gnu.org, mardani29@yahoo.es
Subject: bug#60568: [FR] 30.0.50; Help buffers and function bodies for generated functions
Date: Thu, 05 Jan 2023 17:10:20 +0200 [thread overview]
Message-ID: <83pmbtvwyr.fsf@gnu.org> (raw)
In-Reply-To: <8dea9f3e0e8e6114ffc3@heytings.org> (message from Gregory Heytings on Thu, 05 Jan 2023 14:27:41 +0000)
> Date: Thu, 05 Jan 2023 14:27:41 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: mardani29@yahoo.es, yantar92@posteo.net, 60568@debbugs.gnu.org
>
>
> >> What is missing in the five-line patch that does this? With the
> >> recipe, the file in which org-babel-execute:sh was defined
> >> (ob-shell.el) is opened, and the function definition is displayed. I
> >> don't think we can do much better (e.g. reliably find the place where
> >> the function was defined).
> >
> > Why not? A function definition usually has some specific keywords in
> > it. It is true that someone could have obfuscated the code which
> > generates a function to the degree that it would be infeasible to
> > recognize, but we don't need to support such arbitrary measures, we only
> > need to support what's really being used. IOW, "reliably" doesn't need
> > to mean with 110% reliability.
>
> Hmmm, you mean try to find heuristically where e.g. in the ob-shell.el
> file the org-babel-execute:sh function was defined?
Yes.
> The function body is this:
>
> (lambda
> (body params)
> "Execute a block of sh commands with Babel."
> (let
> ((shell-file-name "sh")
> (org-babel-prompt-command
> (or
> (alist-get "sh" org-babel-shell-set-prompt-commands)
> (alist-get t org-babel-shell-set-prompt-commands))))
> (org-babel-execute:shell body params)))
>
> and it has been created here:
>
> (defun org-babel-shell-initialize ()
> "Define execution functions associated to shell names.
> This function has to be called whenever `org-babel-shell-names'
> is modified outside the Customize interface."
> (interactive)
> (dolist (name org-babel-shell-names)
> (eval `(defun ,(intern (concat "org-babel-execute:" name))
> (body params)
> ,(format "Execute a block of %s commands with Babel." name)
> (let ((shell-file-name ,name)
> (org-babel-prompt-command
> (or (alist-get ,name org-babel-shell-set-prompt-commands)
> (alist-get t org-babel-shell-set-prompt-commands))))
> (org-babel-execute:shell body params))))
> (eval `(defalias ',(intern (concat "org-babel-variable-assignments:" name))
> 'org-babel-variable-assignments:shell
> ,(format "Return list of %s statements assigning to the block's \
> variables."
> name)))
> (eval `(defvar ,(intern (concat "org-babel-default-header-args:" name)) '()))))
>
> Do you think there is a way to find that place?
Well, searching for the regexp "defun .*org-babel-execute:" would have
done that, right?
next prev parent reply other threads:[~2023-01-05 15:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 7:56 bug#60568: [FR] 30.0.50; Help buffers and function bodies for generated functions Ihor Radchenko
2023-01-05 8:09 ` Eli Zaretskii
2023-01-05 8:20 ` Ihor Radchenko
2023-01-05 8:32 ` Eli Zaretskii
2023-01-05 17:04 ` Jean Louis
2023-01-05 17:03 ` Jean Louis
2023-01-05 9:40 ` Gregory Heytings
2023-01-05 9:52 ` Gregory Heytings
2023-01-05 10:45 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 10:52 ` Ihor Radchenko
2023-01-05 11:20 ` Eli Zaretskii
2023-01-05 12:33 ` Gregory Heytings
2023-01-05 14:16 ` Eli Zaretskii
2023-01-05 14:27 ` Gregory Heytings
2023-01-05 15:10 ` Eli Zaretskii [this message]
2023-01-05 15:13 ` Gregory Heytings
2023-01-05 16:49 ` Eli Zaretskii
2023-01-05 20:44 ` Gregory Heytings
2023-01-06 6:35 ` Eli Zaretskii
2023-01-06 9:11 ` Gregory Heytings
2023-01-06 17:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 22:52 ` Gregory Heytings
2023-01-07 0:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-07 6:55 ` Eli Zaretskii
2023-01-07 9:42 ` Gregory Heytings
2023-01-07 13:38 ` Ihor Radchenko
2023-01-07 14:00 ` Eli Zaretskii
2023-01-07 14:04 ` Gregory Heytings
2023-01-07 15:07 ` Ihor Radchenko
2023-01-07 15:14 ` Eli Zaretskii
2023-01-07 15:19 ` Ihor Radchenko
2023-01-07 15:23 ` Eli Zaretskii
2023-01-07 17:59 ` Eli Zaretskii
2023-01-07 13:14 ` Ihor Radchenko
2023-01-07 13:55 ` Eli Zaretskii
2023-01-05 17:00 ` Jean Louis
2023-01-06 8:39 ` Ihor Radchenko
2023-01-06 16:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-07 11:32 ` Ihor Radchenko
2023-01-07 15:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12 10:40 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmbtvwyr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60568@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=mardani29@yahoo.es \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.