all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org
Subject: bug#60557: [PATCH] Fix eglot prompt when connection already exists
Date: Mon, 16 Jan 2023 16:15:28 +0200	[thread overview]
Message-ID: <83pmbe4lbz.fsf@gnu.org> (raw)
In-Reply-To: <87y1q24rx1.fsf@gmail.com> (message from João Távora on Mon, 16 Jan 2023 11:53:14 +0000)

> From: João Távora <joaotavora@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  60557@debbugs.gnu.org
> Date: Mon, 16 Jan 2023 11:53:14 +0000
> 
> [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and
> Eglot is a new package anyway.  Let me know if you'd rather I push this
> to master instead (it doesn't make much of a difference in practice
> since eglot.el is a GNU ELPA packge) ]

The release branch is OK for this kind of changes, thanks.

However, note that this change now causes

  In eglot:
  progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive'

because the INTERACTIVE argument is now unused.  Should it be renamed
to _interactive?





  parent reply	other threads:[~2023-01-16 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 15:44 bug#60557: [PATCH] Fix eglot prompt when connection already exists Evgeni Kolev
2023-01-12  9:35 ` Eli Zaretskii
2023-01-12 10:53   ` João Távora
2023-01-14  6:02     ` Evgeni Kolev
2023-01-14 17:22       ` João Távora
2023-01-16 11:53       ` João Távora
2023-01-16 14:08         ` Eli Zaretskii
2023-01-16 14:15         ` Eli Zaretskii [this message]
2023-01-16 14:42           ` João Távora
2023-01-16 14:54             ` Eli Zaretskii
2023-01-18  5:58               ` Evgeni Kolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pmbe4lbz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60557@debbugs.gnu.org \
    --cc=evgeni.d.kolev@gmail.com \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.