From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62207: 29.0.60; Trying to remove non-existent key binding instead adds a binding Date: Fri, 17 Mar 2023 13:32:48 +0200 Message-ID: <83pm97ehpb.fsf@gnu.org> References: <875yb2gfqp.fsf@bernoul.li> <83pm9aq6of.fsf@gnu.org> <83ttyjeqgm.fsf@gnu.org> <87ilezu5aq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62207@debbugs.gnu.org, larsi@gnus.org, jonas@bernoul.li, monnier@iro.umontreal.ca To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 12:33:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd8Kk-0003Z7-0M for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 12:33:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd8KW-0000nK-9c; Fri, 17 Mar 2023 07:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd8KU-0000mt-N3 for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 07:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd8KU-0001us-AZ for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pd8KT-0006kK-TK for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 07:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62207 X-GNU-PR-Package: emacs Original-Received: via spool by 62207-submit@debbugs.gnu.org id=B62207.167905277725922 (code B ref 62207); Fri, 17 Mar 2023 11:33:01 +0000 Original-Received: (at 62207) by debbugs.gnu.org; 17 Mar 2023 11:32:57 +0000 Original-Received: from localhost ([127.0.0.1]:43824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd8KO-0006k1-HD for submit@debbugs.gnu.org; Fri, 17 Mar 2023 07:32:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd8KM-0006jo-W7 for 62207@debbugs.gnu.org; Fri, 17 Mar 2023 07:32:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd8KG-0001fJ-KI; Fri, 17 Mar 2023 07:32:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZRI2mMUKGvHH5ty3R4+oZFqppI5jSAc82IwWEfQLlkU=; b=mfMr/oQIhdThz89c9kCB G/3370AkXOvfM8oUIE0z/vqk386uLCEr3BznhsOljfzmpohaYIuAFFwyRbbsJXZjWXDE4T5AmirPH URWgy5N/RKd5sy5KGiLEcno/+toFW4CwaKJSpuji1LY8yXUtAwXM5cs25B77OsQsvp3OUZHSY3h3P Hdp004pD7yzPBPheL5WAkXRm9XPl+wRG/AaUBbFbW6NSt4xdJhhI8pTWtn82opCFwzr5Hfw96RPt7 20U812Ov37yozQPngLRQiVxjf02uMhvmKKkVNSIaadGrCYqJEGqIazRExpLIPLbY2Uq1UHBG5H3qr 7uknggpTO6nEIg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd8KF-00057g-Rb; Fri, 17 Mar 2023 07:32:48 -0400 In-Reply-To: <87ilezu5aq.fsf@gmail.com> (message from Robert Pluim on Fri, 17 Mar 2023 09:54:05 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258070 Archived-At: > From: Robert Pluim > Cc: Stefan Monnier , larsi@gnus.org, > jonas@bernoul.li, 62207@debbugs.gnu.org > Date: Fri, 17 Mar 2023 09:54:05 +0100 > > >>>>> On Fri, 17 Mar 2023 10:23:37 +0200, Eli Zaretskii said: > > >> From: Stefan Monnier > >> Cc: Jonas Bernoulli , Lars Ingebrigtsen , > >> 62207@debbugs.gnu.org > >> Date: Wed, 15 Mar 2023 14:02:59 -0400 > >> > >> > Stefan, it sounds like the part of store_in_keymap after the label > >> > keymap_end should do nothing if REMOVE is non-zero, am I right? > >> > >> Sounds right, yes. > > Eli> Then Robert, please install on the emacs-29 branch the part of your > Eli> suggested patch which fixes the problem with REMOVE. The other part > Eli> should go to master, I think. > > The former I can do. Stefan seemed to object to the other part. Itʼs > also not been tested a great deal 😀 OK, then just the emacs-29 part for now. The rest is not urgent anyway. > >> This said, the semantics of REMOVE a bit murky, so I'd rather tell > >> people not to use it. > > Eli> Robert, could you please say something to this effect in the doc > Eli> string? > > Sorry to be difficult, but why? I think the semantics are clear, > although Iʼd prefer it if the first line of the docstring for > `keymap-unset' said > > Unset key sequence KEY in KEYMAP. > > to reduce confusion with the REMOVE argument. If this part is still controversial, I'm okay with only fixing the bug itself. As for REMOVE, let's see what Stefan has to say in defense of his request, and take it from there. Thanks.