From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: treesit indentation "blinking" Date: Wed, 29 Mar 2023 05:26:36 +0300 Message-ID: <83pm8s70o3.fsf@gnu.org> References: <87h6ucik61.fsf@dancol.org> <0F406D08-56D4-4B21-B94D-A47681606911@gmail.com> <1870bcadd28.2829.cc5b3318d7e9908e2c46732289705cb0@dancol.org> <1870cce6690.2829.cc5b3318d7e9908e2c46732289705cb0@dancol.org> <35A837A9-59B4-4F1F-A5FA-8483C8024D76@gmail.com> <187104f6b48.2829.cc5b3318d7e9908e2c46732289705cb0@dancol.org> <21d018e5-a730-12e3-f97c-fffa4f646ccf@yandex.ru> <83v8ioc2ou.fsf@gnu.org> <87sfdsx0r2.fsf@gmail.com> <87lejgsf0m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, dancol@dancol.org, casouri@gmail.com, emacs-devel@gnu.org, theo@thornhill.no To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 29 04:27:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phLX2-0004Or-Cw for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Mar 2023 04:27:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phLWF-0005ZS-Pt; Tue, 28 Mar 2023 22:26:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phLWD-0005Z5-Bk for emacs-devel@gnu.org; Tue, 28 Mar 2023 22:26:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phLWB-000725-02; Tue, 28 Mar 2023 22:26:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B6SfJLh+0tTRDfRNdFWog1roKpKPxPe6VcXYFXzk0CI=; b=CvMO8vT5QjarN7F7DmSN ZodjXSNmwH7kLMWBGCUwtDr6qCS4tmHofmsTGH8ueeWeVvUKFm5Fx7bNcMatnM/9i3xRyOTI0JnMJ 1d1+JG6yLCROaotQco4F9cWg89+uifmjMhRxp8ZVDbVkKipkl3pTU1wlSTEMtd0xC0buSNnySCtA4 Qdn/Ffjf5pjqr7oBJxpmxAjXxR/geHT1rr0PUn0HTyvy+Na03Yl4wOg6QCVIr1QyZVnSVuwkw1qXt CHFqqMsCErly70kUmVgrZrI0Z4+ChhwhMUDfTPVTuBNas5U0idPtbO5RVWxM/d8AQVqk9Lb04OS5B 2kd42D6qqKxZvw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phLWA-0000Jd-4m; Tue, 28 Mar 2023 22:26:30 -0400 In-Reply-To: <87lejgsf0m.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Tue, 28 Mar 2023 23:11:05 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304813 Archived-At: > From: João Távora > Cc: Dmitry Gutov , dancol@dancol.org, casouri@gmail.com, > emacs-devel@gnu.org, theo@thornhill.no > Date: Tue, 28 Mar 2023 23:11:05 +0100 > > Though a number of indenting problems would remain after that, at least > this one clear annoyance would be solved. So if there are no > objections, I propose to apply this patch. > > diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el > index 59eb9fc23e6..88360716381 100644 > --- a/lisp/progmodes/c-ts-mode.el > +++ b/lisp/progmodes/c-ts-mode.el > @@ -956,10 +956,6 @@ c-ts-base-mode > ;; Comment > (c-ts-common-comment-setup) > > - ;; Electric > - (setq-local electric-indent-chars > - (append "{}():;,#" electric-indent-chars)) > - > ;; Imenu. > (setq-local treesit-simple-imenu-settings > (let ((pred #'c-ts-mode--defun-valid-p)) > > In master? In emacs-29? I suggest to do this in emacs-29, but conditionally, with a defcustom. This will allow users to try both ways and maybe we will have some feedback regarding what is the best way. I'm also interested to know what other editors do, as Daniel points out.