From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Fri, 07 Apr 2023 16:48:23 +0300 Message-ID: <83pm8folaw.fsf@gnu.org> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile9t5uj.fsf@gmx.de> <87ttxssyef.fsf@gmx.de> <87o7o0rvax.fsf@gmx.de> <835ya8otvh.fsf@gnu.org> <83355cot57.fsf@gnu.org> <83wn2ondpe.fsf@gnu.org> <83v8i7opz4.fsf@gnu.org> <87wn2n51qr.fsf@gmx.de> <83sfdbopa8.fsf@gnu.org> <87ttxr3l1b.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9373"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62694@debbugs.gnu.org, joaotavora@gmail.com To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 07 15:49:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkmSs-0002CK-Im for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Apr 2023 15:49:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkmSe-0000tL-89; Fri, 07 Apr 2023 09:49:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmSc-0000tD-Q0 for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 09:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkmSc-0001T5-F1 for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 09:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkmSc-0002VK-80 for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 09:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Apr 2023 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.16808752849413 (code B ref 62694); Fri, 07 Apr 2023 13:49:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 7 Apr 2023 13:48:04 +0000 Original-Received: from localhost ([127.0.0.1]:56002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmRf-0002Rj-K4 for submit@debbugs.gnu.org; Fri, 07 Apr 2023 09:48:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmRd-0002Qd-BK for 62694@debbugs.gnu.org; Fri, 07 Apr 2023 09:48:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmRS-0000WP-Nj; Fri, 07 Apr 2023 09:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aJUEv+c076carTVULuHNiHgsfv5KEEsk/ZUfsLGB1kk=; b=aLRz15oMJsd1 JrYrrFFLKJB9F61b/3oufPjoX/767J6ElIzEOD3yQCamQJw3uwECxOiUVho0ifhRfvti40amf5mBF uZmdF7MM+RoS2iWuo6kKOT0s/bjCYeV4r52Eqg65ojz0TlIs7LRuMj/x4LsJE9Pg0NZTDZM5WX5lk exi5Ea2+H8algnGP319EMvPxFbsnan/VdsCrsLBnK1jxX0ksNU6b9Xw29I9LsxqcHkqDdZZgwnv2u rdcCqTeSGylYxkA9SnXojLtZQxRvsxIlER1Ot1l2xJXDtWdY7VVHtLn3tLka7OKYZWd4nakBbGrRL 1W7p+QWAiRv2Q7JdpyLIdA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmRS-0002ns-1Z; Fri, 07 Apr 2023 09:47:50 -0400 In-Reply-To: <87ttxr3l1b.fsf@gmx.de> (message from Michael Albinus on Fri, 07 Apr 2023 14:59:44 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259418 Archived-At: > From: Michael Albinus > Cc: 62694@debbugs.gnu.org, joaotavora@gmail.com > Date: Fri, 07 Apr 2023 14:59:44 +0200 > > Eli Zaretskii writes: > > >> > Alternatively, we could mark these tests as known to fail, right? > >> > >> This would be unfortune if there is a pylsp version on the machine which > >> let the tests succeed. > > > > Why unfortunate? what am I missing? > > On my laptop, where the eglot pylsp tests pass, "mark these tests as > known to fail" would result in something like this: > > --8<---------------cut here---------------start------------->8--- > (ert-deftest foo () > :expected-result :failed > (should t)) > > M-x ert RET foo RET > > Selector: foo > Passed: 1 (1 unexpected) > Failed: 0 > Skipped: 0 > Total: 1/1 > > Started at: 2023-04-07 14:52:01+0200 > Finished. > Finished at: 2023-04-07 14:52:01+0200 > > P > > P foo > passed unexpectedly > --8<---------------cut here---------------end--------------->8--- > > The test foo is marked red in the *ert* buffer. I understand, but I don't see this as a problem, FWIW. However, if you prefer marking them as unstable, I'm okay with that.