From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63550: proced-refine-with-update-test is racy Date: Sun, 21 May 2023 14:20:06 +0300 Message-ID: <83pm6uq6c9.fsf@gnu.org> References: <875y8rrxly.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29986"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, mattias.engdegard@gmail.com, 63550@debbugs.gnu.org To: Laurence Warne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 21 13:20:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0h6o-0007cU-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 May 2023 13:20:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0h6e-0006R3-MT; Sun, 21 May 2023 07:20:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0h6b-0006Qe-4s for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 07:20:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0h6Y-0005eq-Ak for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 07:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q0h6Y-0007QB-5o for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 07:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 May 2023 11:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63550 X-GNU-PR-Package: emacs Original-Received: via spool by 63550-submit@debbugs.gnu.org id=B63550.168466799428510 (code B ref 63550); Sun, 21 May 2023 11:20:02 +0000 Original-Received: (at 63550) by debbugs.gnu.org; 21 May 2023 11:19:54 +0000 Original-Received: from localhost ([127.0.0.1]:60123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0h6Q-0007Pm-4s for submit@debbugs.gnu.org; Sun, 21 May 2023 07:19:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0h6O-0007PZ-BP for 63550@debbugs.gnu.org; Sun, 21 May 2023 07:19:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0h6I-0005YB-KR; Sun, 21 May 2023 07:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=UhKIeE6L2sQgR1vPJzVlXYfAhA/97ES8BKek0BM0pS0=; b=mWzI98TG+86tlwNOScXb /+tK3apRI1EZGf8Hl7CmAnz6mwdBpC7/7H5qArxIspUxkGT49oQxEAV20x08azH2Me0ikdeBUSD1G hSsfXjf+mxyms9pJeiew2gFN2Feu+mUycuTx5nyJP3UZXidWlXVaN54V0rqHa1f+CsXpqNX9Dw9Hb 23IP/hLnQRd41NR0XUlXwCo/13KBeMSXQPMAXPJ0XOyLhe+nHB9NSsdisj5XiIz+kjYpME2t/z5OT hyOcUA1tqdP4PfTfawnJh1It12gNdnefszUdAlfEMP3o5QXw/o7HkEgcCBbHj/uotZ4LLaRSCUppG OtmjB787rm0A8Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0h6I-0008A8-3y; Sun, 21 May 2023 07:19:46 -0400 In-Reply-To: (message from Laurence Warne on Sun, 21 May 2023 09:37:10 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262101 Archived-At: > Cc: Mattias Engdegård , > 63550@debbugs.gnu.org > From: Laurence Warne > Date: Sun, 21 May 2023 09:37:10 +0100 > > Strange, I can't seem to reproduce running it continuously (I'm on linux also). Though whilst looking > over the test suite, I don't think I like the approach I took. I've attached a new patch which changes the > test suite to mock the list of active processes (of course comments welcome). > > Are either of you able to test whether this fixes the test in question? The change also makes the tests > a lot faster to run and hopefully less system dependent. Is mocking out the real Proced display a good idea in this case? These tests test the ability to manipulate real-life process-attribute displays, so showing they work in synthetic environment verifies only part of the functionality, no?