From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 15:08:25 +0300 Message-ID: <83pm6b5t1i.fsf@gnu.org> References: <83y1l7gzqw.fsf@gnu.org> <87ilcb2p1l.fsf@posteo.net> <87sfb8g85v.fsf@posteo.net> <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> <87h6rnoa8v.fsf@posteo.net> <83v8g35ybo.fsf@gnu.org> <87cz2bo3qu.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7463"; mail-complaints-to="usenet@ciao.gmane.io" Cc: artscan@list.ru, 63757@debbugs.gnu.org, monnier@iro.umontreal.ca To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 14:08:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5mWz-0001mT-15 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 14:08:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5mWl-0008AY-9S; Sun, 04 Jun 2023 08:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5mWh-0008AB-TC for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5mWg-0003At-Jx for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5mWg-0007Jc-Fc for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168588046228092 (code B ref 63757); Sun, 04 Jun 2023 12:08:02 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 12:07:42 +0000 Original-Received: from localhost ([127.0.0.1]:45198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5mWL-0007J1-PO for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:07:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5mWJ-0007Ip-PN for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 08:07:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5mWC-00034B-Tf; Sun, 04 Jun 2023 08:07:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uSik9xb3CkqG5vSTaDEwfkINSIfvLkk4ywIiWCJ/u34=; b=PRSb/T/IztCd w32liMXvMOgV7GGh2PszDcUo9DNId52J2PMRrTz1TWxakT9mbzcEa4VjSRQe8aRDqhfuZ7wvPtJDI ZzyRs7UPXZNYa269tuv1QkUhb2JejnjIepR8XQcLK1HYI7ptsC1WH2bA5DMyZS+6VGerQRpB5qNcP w9N2Tjg08RZuyo4QfmeXJndJ57qgcQyPbfMc7hqT0SLnPhpWL2sIaMRHO7m8OSAmuUsa4CuaLByE2 eU6WiPgohTzMJplWmSzVMemNjQejbYAD/PoONblbwrcgIjShTp8lhvPYWzMeEXz9KWQ1MYNVXoCiT xsR1fpDSWv+OrtLzEYnITw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5mWC-0007xn-Db; Sun, 04 Jun 2023 08:07:32 -0400 In-Reply-To: <87cz2bo3qu.fsf@posteo.net> (message from Philip Kaludercic on Sun, 04 Jun 2023 11:39:53 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262938 Archived-At: > From: Philip Kaludercic > Cc: artscan@list.ru, monnier@iro.umontreal.ca, 63757@debbugs.gnu.org > Date: Sun, 04 Jun 2023 11:39:53 +0000 > > Eli Zaretskii writes: > > > Is that a reverse diff or something? The code we have now already > > does sort the list... > > No, the current code passes a non-nil NOSORT flag to `directory-files', > which inhibits sorting? I'm confused. The code which the patch adds, viz.: > (defun package--get-activatable-pkg (pkg-name) > ;; Is "activatable" a word? > - (let ((pkg-descs (cdr (assq pkg-name package-alist)))) > + (let ((pkg-descs (sort (cdr (assq pkg-name package-alist)) > + (lambda (p1 p2) > + (let ((v1 (package-desc-version p1)) > + (v2 (package-desc-version p2))) > + (or > + ;; Prefer source packages. > + (eq (package-desc-kind p1) 'vc) > + (not (eq (package-desc-kind p2) 'vc)) > + ;; Prefer builtin packages. > + (package-disabled-p p1 v1) > + (not (package-disabled-p p2 v2)))))))) > ;; Check if PACKAGE is available in `package-alist'. is already in the version of package.el on the emacs-29 branch. And the code which the patch removes, viz.: > ;; Check if PACKAGE is available in `package-alist'. > (while > (when pkg-descs > (let ((available-version (package-desc-version (car pkg-descs)))) > - (or (package-disabled-p pkg-name available-version) > - ;; Prefer a builtin package. > - (package-built-in-p pkg-name available-version)))) > + (package-disabled-p pkg-name available-version))) > (setq pkg-descs (cdr pkg-descs))) > (car pkg-descs))) is already removed on the emacs-29 branch. What am I missing here?