all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Matthias Meulien <orontee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: About commands to manage Python imports
Date: Sat, 01 Jul 2023 19:45:35 +0300	[thread overview]
Message-ID: <83pm5bpols.fsf@gnu.org> (raw)
In-Reply-To: <CAFEQCfAyRcvLSMw3pA6oAdHYOWrHa1G-NKZL4Tiu_A_hEfaa6A@mail.gmail.com> (message from Matthias Meulien on Sat, 1 Jul 2023 18:14:32 +0200)

> From: Matthias Meulien <orontee@gmail.com>
> Date: Sat, 1 Jul 2023 18:14:32 +0200
> 
> If I read the logs correctly, commands python-add-import, python-fix-imports, etc. will be introduced
> with Emacs 29. I am surprised there's no NEWS item related to those commands. Are the menu
> entries considered enough?

It's an omission.  Feel free to write a NEWS entry and post it.

> --- a/lisp/progmodes/python.el
> +++ b/lisp/progmodes/python.el
> @@ -6420,7 +6420,7 @@ python--list-imports
>                                  (mapcar #'file-local-name source)))))
>               lines)
>          (unless (eq 0 status)
> -          (error "%s exited with status %s (maybe isort is missing?)"
> +          (error "%s exited with status %s (maybe isort>=5.7.0 is missing?)"
>                   python-interpreter status))
>          (goto-char (point-min))
>          (while (not (eobp))
> @@ -6465,7 +6465,7 @@ python--do-isort
>                                 "-m" "isort" "-" args))
>                  (tick (buffer-chars-modified-tick)))
>              (unless (eq 0 status)
> -              (error "%s exited with status %s (maybe isort is missing?)"
> +              (error "%s exited with status %s (maybe isort>=5.7.0 is missing?)"

Thanks, but the "isort>=5.7.0" part is quite cryptic.  Can we do
better?



  reply	other threads:[~2023-07-01 16:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-01 16:14 About commands to manage Python imports Matthias Meulien
2023-07-01 16:45 ` Eli Zaretskii [this message]
2023-07-01 19:23   ` Matthias Meulien
2023-07-01 20:19     ` Matthias Meulien
2023-07-02  4:49     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pm5bpols.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=orontee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.