From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [elpa] externals/compat 6a60af22da: Optimize string-search
Date: Fri, 11 Aug 2023 09:23:33 +0300
Message-ID: <83pm3ugkre.fsf@gnu.org>
References: <169158945793.6388.8459711282582712176@vcs2.savannah.gnu.org>
 <20230809135738.457BDC038BF@vcs2.savannah.gnu.org> <87jzu2jemz.fsf@posteo.net>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="9965"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, mail@daniel-mendler.de
To: Philip Kaludercic <philipk@posteo.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 11 08:24:00 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1qULZ1-0002M8-Mq
	for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Aug 2023 08:23:59 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1qULYE-0002sf-7h; Fri, 11 Aug 2023 02:23:10 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1qULYA-0002sH-U5
 for emacs-devel@gnu.org; Fri, 11 Aug 2023 02:23:08 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1qULY9-0008Bo-6B; Fri, 11 Aug 2023 02:23:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=xD4Q2I7znR2fzjME6XCerqjh8vUEJzDewjkhU88nbJg=; b=R0LY9QxSyz8P
 Brpv2/bN/0FV+N9+oxjjo/KOYKVbdoYLCc6WTNG6P0D05IcxzYPbUavEBHGQVeXnpD860aJ6UnBSd
 Vs/0s238ciBCnoGQg64Kck3hX5a5Lu6zasIDQrdIfrrj/+ZGJR+Sq8uJTEMVZEV1tNCafnFltj+hc
 ZdqQCJC66OsBTlWtOY/mIwujwaM+w3Gi8RkDM4ypFDmuyBK0yiAhD7x81hMN8FNEhe2Kvhr/0J+hT
 fbwBkpVGM555Xy6q6/AGRH52sVkYJhlcNvpWvWl+59NRakFoqzROt73Pg+9nwGBqeaiW3s4mWH+GV
 Aj9haVCVGWCb1E19oj6TRg==;
In-Reply-To: <87jzu2jemz.fsf@posteo.net> (message from Philip Kaludercic on
 Fri, 11 Aug 2023 06:07:32 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:308557
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/308557>

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: Daniel Mendler <mail@daniel-mendler.de>
> Date: Fri, 11 Aug 2023 06:07:32 +0000
> 
> I don't believe this is a legal optimisation, even if the regular
> expression is quoted.

It is certainly "legal", in the sense that it breaks no laws.

The GNU Coding Standards frown on using "legal" or "illegal" for
anything that doesn't involve the laws and jurisprudence; we use
"valid" and "invalid" instead.