From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: larsi@gnus.org, 65156@debbugs.gnu.org, mail@lucaswerkmeister.de
Subject: bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported
Date: Sat, 12 Aug 2023 11:05:33 +0300 [thread overview]
Message-ID: <83pm3selde.fsf@gnu.org> (raw)
In-Reply-To: <a8b32bff-a22d-ce9f-f16d-4d5fd4795be1@cs.ucla.edu> (message from Paul Eggert on Fri, 11 Aug 2023 14:45:48 -0700)
> Date: Fri, 11 Aug 2023 14:45:48 -0700
> Cc: mail@lucaswerkmeister.de, larsi@gnus.org, 65156@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> On 2023-08-11 11:30, Eli Zaretskii wrote:
> > This is fine, but I think instead of "act as if REPLACE were nil" we
> > should explicitly say that the buffer is erased and the file's
> > contents is inserted.
>
> I'm still a bit lost here. It's news to me that REPLACE being nil means
> the entire buffer is erased first.
That's actually a bug: it should only erase the accessible portion of
the buffer. I fixed it now.
> The bigger picture is that I don't know what insert-file-contents is
> supposed to do in all these complicated circumstances. THat is the
> various motivations behind insert-file-contents's complex argument
> combinations don't fully make sense to me. So I'll step aside and let
> someone more expert fix the doc string, whenever anybody has the time.
Until we wait for someone to figure that out, I attempted to make
things better by fixing the doc string's language as best I could, see
the master branch.
WDYT about backporting this (both the doc string and the erasing fix)
to emacs-29?
next prev parent reply other threads:[~2023-08-12 8:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 18:20 bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported Lucas Werkmeister
2023-08-08 18:33 ` Eli Zaretskii
2023-08-08 19:27 ` Eli Zaretskii
2023-08-09 2:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 11:31 ` Eli Zaretskii
2023-08-09 20:57 ` Paul Eggert
2023-08-10 5:17 ` Eli Zaretskii
2023-08-10 6:08 ` Paul Eggert
2023-08-10 8:15 ` Eli Zaretskii
2023-08-11 17:18 ` Paul Eggert
2023-08-11 18:30 ` Eli Zaretskii
2023-08-11 21:45 ` Paul Eggert
2023-08-12 8:05 ` Eli Zaretskii [this message]
2023-08-12 8:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 8:07 ` Mattias Engdegård
2023-08-09 8:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 8:29 ` Mattias Engdegård
2023-08-09 12:00 ` Eli Zaretskii
2023-08-09 12:03 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pm3selde.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65156@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=larsi@gnus.org \
--cc=mail@lucaswerkmeister.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.