From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63627: Improve plstore.el and fix various issues of it Date: Sat, 02 Sep 2023 10:41:53 +0300 Message-ID: <83pm319g3i.fsf@gnu.org> References: <2063d5d2-ae9e-020a-3c19-54508ddbabab@vodafonemail.de> <37949bc5-c572-ff98-ebe6-9217ab7067cc@vodafonemail.de> <83cz2gfypg.fsf@gnu.org> <0101e7f1-970b-297c-836f-e9c0aa5e38a0@vodafonemail.de> <83cyz3g6oc.fsf@gnu.org> <8b00a564-c0d2-3072-50bc-530c50fa25b2@vodafonemail.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20486"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63627@debbugs.gnu.org To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 09:43:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcLHk-0005Ac-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 09:43:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcLHS-0004LX-9g; Sat, 02 Sep 2023 03:42:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcLHQ-0004Kx-Ud for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 03:42:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcLHQ-0002sW-Mg for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 03:42:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcLHa-0003xu-8u for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 03:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63627 X-GNU-PR-Package: emacs Original-Received: via spool by 63627-submit@debbugs.gnu.org id=B63627.169364054215189 (code B ref 63627); Sat, 02 Sep 2023 07:43:02 +0000 Original-Received: (at 63627) by debbugs.gnu.org; 2 Sep 2023 07:42:22 +0000 Original-Received: from localhost ([127.0.0.1]:35047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLGw-0003wv-As for submit@debbugs.gnu.org; Sat, 02 Sep 2023 03:42:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLGv-0003wi-5H for 63627@debbugs.gnu.org; Sat, 02 Sep 2023 03:42:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcLGf-0002oZ-Gm; Sat, 02 Sep 2023 03:42:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LTlPG//YEVJaaccvZdDwyl/AJYpb8qhfCteCDEM4Bo8=; b=Akq/cNgYxUVW plNl/j+9s6F+epdBlNam+G5FZNHQv3axnlWlzYfAQhHuGDx2yuyRxkYAd+PYt9iPtEkS6oAVQUyza vWFEXq/8PT+uhTNDu78NUvSkga/miUEGFhdNfMgZfsTcKM+f9ulQBgi45anRdOSVVNzwM5mY9d2gD CEUMlOFp/mdYULVkwcG+/2orn6ABXbkDfKn/FNXqiyCnNfUhA/MbiXP0g9RM90h+tkoacR7zWXk2H fikuPJYkwkXfj+VIFL5L06+CBglFv2B8KUxHwBi+gEVYK3338BEVUhRtWVG7f55bjer7/pYMs5XxC jYaUMyMOEZSo1meCjRmBRA==; In-Reply-To: <8b00a564-c0d2-3072-50bc-530c50fa25b2@vodafonemail.de> (message from Jens Schmidt on Thu, 31 Aug 2023 12:21:38 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268962 Archived-At: > Date: Thu, 31 Aug 2023 12:21:38 +0200 > Cc: 63627@debbugs.gnu.org > From: Jens Schmidt > > On 2023-08-31 06:46, Eli Zaretskii wrote: > >> Date: Wed, 30 Aug 2023 21:28:10 +0200 > >> Cc: 63627@debbugs.gnu.org > >> From: Jens Schmidt > > >> Next set of patches, I hope they are still eligible for emacs-29. > >> > >> The first patch fixes more documentation and terminology issues in > >> plstore.el, still without touching any code. The second patch > >> comprise ERT tests for plstore.el. Since that requires interaction > >> with GnuPG, these tests are rather platform-dependent. Test setup > >> should ensure that all tests are skipped if GnuPG is missing or not > >> appropriate for the tests. > > > > Documentation fixes are always welcome on the release branch. > > > > As for tests: I don't really object, but what would be the purpose of > > extending the test suite on the release branch? why not install that > > on master instead? > > I thought about adding tests for 1-2 pending bugs in plstore.el in near > future. But OTOH, these bugs are really not that significant, so > probably it makes indeed more sense to add the tests to master only. OK, so I've now installed the documentation changes on emacs-29. Please prepare the other patch for master, and let's install it there. > >> Please check. > > > > What would you like me to check? > > Nothing in particular. Like: "Please check whatever you must check > before committing such changes." > > Actually, it *would* be interesting to know what you check in such a > situation, if it could be easily described. I look at the commit log message, make sure the relevant tests still pass, and do anything else my eyes suggest while looking at the patch. Thanks.