From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65854: Multi-file replacement diff Date: Fri, 15 Sep 2023 10:38:23 +0300 Message-ID: <83pm2jkhsg.fsf@gnu.org> References: <86sf7mgd54.fsf@mail.linkov.net> <86bke943tp.fsf@mail.linkov.net> <83jzswrios.fsf@gnu.org> <86o7i7oo9t.fsf@mail.linkov.net> <86sf7g548a.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28302"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@eshelyaron.com, 65854@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 09:39:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh3Q1-00077b-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 09:39:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh3Pm-0001tu-6K; Fri, 15 Sep 2023 03:38:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh3Pk-0001tj-5b for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:38:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh3Pj-0008U0-Tg for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:38:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh3Pq-0007C3-5S for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 07:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65854-submit@debbugs.gnu.org id=B65854.169476352527625 (code B ref 65854); Fri, 15 Sep 2023 07:39:02 +0000 Original-Received: (at 65854) by debbugs.gnu.org; 15 Sep 2023 07:38:45 +0000 Original-Received: from localhost ([127.0.0.1]:41955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3PY-0007BV-RM for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:38:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3PW-0007BG-Cg for 65854@debbugs.gnu.org; Fri, 15 Sep 2023 03:38:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh3PK-0008PQ-Ko; Fri, 15 Sep 2023 03:38:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/m05aJgJ12VXpWtBSkQTk1TTxPL6OPNWly/I+SEsXZs=; b=EtnI4W2VjZAb MDTLXJ2+r47vn9f6i384IPyLA/eu/pf6aPi7eiln7xKIUNOp5j1aUjRju0B2mm1hkcECYrT2KjtuV HclpRn+UJTrUHAmNUkZJQYbrhKzlDU5WUeUIJneX/sXM1Zfv2XFx2+7eQP856+ujgy/KUkL+prhhG Df/Dy7vKIQW4wavCEzIk88U++A1W8T/6h2GysOtRA3v2M3Us58f5GPPmLnWMOo/Fad5nPwm7KQviX EOfImnwlewEbo8X0/9sGDAp9keAKxumDvf5nmJ1ScUrdVVg/oI+12Yxumam7HPtCqyxyYxgi1Bqp4 3SQRZ/NG+/YJM+lzE21HQw==; In-Reply-To: <86sf7g548a.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 15 Sep 2023 09:40:21 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270505 Archived-At: > From: Juri Linkov > Cc: Eshel Yaron , 65854@debbugs.gnu.org > Date: Fri, 15 Sep 2023 09:40:21 +0300 > > +(defcustom multi-file-diff-unsaved 'use-file > + "A choice defining what to do with unsaved changes. This first sentence is too general. I suggest What to do with unsaved edits when showing multi-file replacements as diffs. > +(defun multi-file-replace-regexp-as-diff (files regexp to-string &optional delimited) > + "Show replacements in FILES matching REGEXP with TO-STRING as diff. Show as diffs replacements of REGEXP with TO-STRING in FILES. > +With a prefix argument, ask for a wildcard, and replace in files "replace"? Does this command perform replacements or just shows them as diffs? The first sentence seems to convey the latter. > +(defun multi-buffer-replace-regexp-as-diff (buffers regexp to-string &optional delimited) > + "Show replacements in file BUFFERS matching REGEXP with TO-STRING as diff. > +With a prefix argument, ask for a regexp, and replace in file buffers > +whose names match the specified regexp." Same comments here. > +(defun replace-regexp-as-diff (regexp to-string &optional delimited) > + "Show replacements in the current file buffer matching REGEXP with TO-STRING as diff. > +With a prefix argument, ask for a regexp, and replace in file buffers > +whose names match the specified regexp." And here. Thanks.