all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 66150@debbugs.gnu.org, michael.albinus@gmx.de
Subject: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache
Date: Fri, 22 Sep 2023 14:37:51 +0300	[thread overview]
Message-ID: <83pm2a781c.fsf@gnu.org> (raw)
In-Reply-To: <87wmwimto3.fsf@epfl.ch> (bug-gnu-emacs@gnu.org)

> Cc: Michael Albinus <michael.albinus@gmx.de>
> Date: Fri, 22 Sep 2023 11:41:32 +0200
> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Building master, I see the following warning:
> 
>   In toplevel form:
>   files.el:1327:12: Warning: in defcustom for ‘remote-file-name-inhibit-cache’:
>   duplicated :tag string in ‘choice’: "Do not use file name cache"
> 
> Is the following patch acceptable?

With changes, see below.

> -	  (const   :tag "Do not inhibit file name cache" nil)
> -	  (const   :tag "Do not use file name cache" t)
> -	  (integer :tag "Do not use file name cache"
> -		   :format "Do not use file name cache older then %v seconds"
> +          (const   :tag "Inhibit remote file cache" t)
> +          (const   :tag "Cache remote file attributes" nil)
> +          (integer :tag "Cache remote file attributes with expiration"
> +                   :format "Cache expiry in seconds: %v"
>  		   :value 10)))

Let's be consistent.  Either (a) the t value should have the tag of
"Do not cache remote file attributes", or (b) the nil and the integer
values should have the tag "Do not inhibit remote file cache" and
"Inhibit file cache if expired", respectively.  OK?

> If it's acceptable, does it belong on master or emacs-29?

emacs-29, please.





  parent reply	other threads:[~2023-09-22 11:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22  9:41 bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-22 10:01 ` Michael Albinus
2023-09-22 11:24   ` Stefan Kangas
2023-09-22 10:01 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-22 11:37 ` Eli Zaretskii [this message]
2023-09-22 13:19   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pm2a781c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=66150@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.